You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (JIRA)" <ji...@apache.org> on 2016/10/16 20:30:20 UTC

[jira] [Created] (MRESOLVER-4) Use Commons Lang's Validate to intercept invalid input

Michael Osipov created MRESOLVER-4:
--------------------------------------

             Summary: Use Commons Lang's Validate to intercept invalid input
                 Key: MRESOLVER-4
                 URL: https://issues.apache.org/jira/browse/MRESOLVER-4
             Project: Maven Resolver
          Issue Type: Improvement
    Affects Versions: Maven Artifact Resolver 1.2.0
            Reporter: Michael Osipov
            Assignee: Michael Osipov
            Priority: Minor
             Fix For: Maven Artifact Resolver 1.2.0


In several spots of Maven Resolver IAE is thrown where an argument is null. This should be turned into NullPointerException since JDK adheres to is and the description of this exception indicates that and Effective Java does that too.

Most likely to be misused:
{noformat}
$ grep -r "throw new IllegalArgumentException" .
./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java:            throw new IllegalArgumentException( "Bad artifact coordinates " + coords
./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:            throw new IllegalArgumentException( "no type id specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:            throw new IllegalArgumentException( "no type id specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:            throw new IllegalArgumentException( "dependency collection request has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java:            throw new IllegalArgumentException( "repository system session not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:            throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:            throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:            throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java:            throw new IllegalArgumentException( "deploy request has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java:            throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java:            throw new IllegalArgumentException( "no artifact specified for dependency" );
./maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java:            throw new IllegalArgumentException( "install request has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java:            throw new IllegalArgumentException( "metadata nature was not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:            throw new IllegalArgumentException( "repository system session missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:            throw new IllegalArgumentException( "authentication data key missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:            throw new IllegalArgumentException( "authentication data key missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java:            throw new IllegalArgumentException( "local artifact request has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java:            throw new IllegalArgumentException( "local metadata request has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java:                throw new IllegalArgumentException( "repository prototype missing" );
./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:                throw new IllegalArgumentException( "session not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:                throw new IllegalArgumentException( "event type not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactDescriptorResult.java:            throw new IllegalArgumentException( "artifact descriptor request has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactResult.java:            throw new IllegalArgumentException( "resolution request has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/DependencyResult.java:            throw new IllegalArgumentException( "dependency request has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/MetadataResult.java:            throw new IllegalArgumentException( "metadata request has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/VersionRangeResult.java:            throw new IllegalArgumentException( "version range request has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/VersionResult.java:            throw new IllegalArgumentException( "version request has not been specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "session not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "transfer resource not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "event type not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "event type not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "request type not specified" );
./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "number of transferred bytes cannot be negative" );
./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "number of transferred bytes cannot be negative" );
./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferResource.java:            throw new IllegalArgumentException( "resume offset cannot be negative" );
./maven-resolver-api/src/main/java/org/eclipse/aether/version/VersionRange.java:                throw new IllegalArgumentException( "version missing" );
./maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:                throw new IllegalArgumentException( "destination file has not been specified" );
./maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:                throw new IllegalArgumentException( "source file has not been specified" );
./maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnectorFactory.java:            throw new IllegalArgumentException( "transporter provider has not been specified" );
./maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnectorFactory.java:            throw new IllegalArgumentException( "repository layout provider has not been specified" );
./maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnectorFactory.java:            throw new IllegalArgumentException( "checksum policy provider has not been specified" );
./maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnectorFactory.java:            throw new IllegalArgumentException( "file processor has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/impl/DefaultServiceLocator.java:                throw new IllegalArgumentException( "service type not specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/impl/DefaultServiceLocator.java:                        throw new IllegalArgumentException( "service instance not specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/impl/DefaultServiceLocator.java:                throw new IllegalArgumentException( "implementation class not specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/impl/DefaultServiceLocator.java:            throw new IllegalArgumentException( "service type not specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "file processor has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "repository event dispatcher has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "version resolver has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "update check manager has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "repository connector provider has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "remote repository manager has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "sync context factory has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "offline controller has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyCollector.java:            throw new IllegalArgumentException( "remote repository manager has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyCollector.java:            throw new IllegalArgumentException( "artifact descriptor reader has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyCollector.java:            throw new IllegalArgumentException( "version range resolver has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyGraphTransformationContext.java:            throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyGraphTransformationContext.java:            throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "file processor has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "repository event dispatcher has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "repository connector provider has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "remote repository manager has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "update check manager has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "metadata generator factory has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "sync context factory has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "offline controller has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:            throw new IllegalArgumentException( "file processor has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:            throw new IllegalArgumentException( "repository event dispatcher has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:            throw new IllegalArgumentException( "metadata generator factory has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:            throw new IllegalArgumentException( "sync context factory has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:                throw new IllegalArgumentException( "Cannot install " + dstFile + " to same path" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:                    throw new IllegalArgumentException( "Cannot install " + dstFile + " to same path" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultLocalRepositoryProvider.java:            throw new IllegalArgumentException( "Local repository manager factory has not been specified." );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java:            throw new IllegalArgumentException( "repository event dispatcher has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java:            throw new IllegalArgumentException( "update check manager has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java:            throw new IllegalArgumentException( "repository connector provider has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java:            throw new IllegalArgumentException( "remote repository manager has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java:            throw new IllegalArgumentException( "sync context factory has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java:            throw new IllegalArgumentException( "offline controller has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRemoteRepositoryManager.java:            throw new IllegalArgumentException( "update policy analyzer has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRemoteRepositoryManager.java:            throw new IllegalArgumentException( "checksum policy provider has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java:            throw new IllegalArgumentException( "repository connector factory has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java:            throw new IllegalArgumentException( "remote repository has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryEventDispatcher.java:            throw new IllegalArgumentException( "repository listener has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryLayoutProvider.java:            throw new IllegalArgumentException( "layout factory has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryLayoutProvider.java:            throw new IllegalArgumentException( "remote repository has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "version resolver has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "version range resolver has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "artifact resolver has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "metadata resolver has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "artifact descriptor reader has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "dependency collector has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "installer has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "deployer has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "local repository provider has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "sync context factory has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "remote repository manager has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "dependency node or collect request missing" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( e.getMessage(), e );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "Invalid repository system session: the session may not be null." );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:        throw new IllegalArgumentException( "Invalid repository system session: " + name + " is not set." );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTransporterProvider.java:            throw new IllegalArgumentException( "transporter factory has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTransporterProvider.java:            throw new IllegalArgumentException( "remote repository has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java:            throw new IllegalArgumentException( "update policy analyzer has not been specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java:            throw new IllegalArgumentException( String.format( "The artifact '%s' has no file attached", artifact ) );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java:            throw new IllegalArgumentException( String.format( "The metadata '%s' has no file attached", metadata ) );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/EnhancedLocalRepositoryManager.java:            throw new IllegalArgumentException( "artifact to register not specified" );
./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/SimpleLocalRepositoryManager.java:            throw new IllegalArgumentException( "base directory has not been specified" );
./maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultDependencyCollectorTest.java:            throw new IllegalArgumentException( "Illegal coordinates for child", e );
./maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultDependencyCollectorTest.java:            throw new IllegalArgumentException( "Illegal coordinates for child", e );
./maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/layout/RepositoryLayout.java:                throw new IllegalArgumentException( "resource location must not have query parameters: " + location );
./maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/layout/RepositoryLayout.java:                throw new IllegalArgumentException( "resource location must not have a fragment: " + location );
./maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/layout/RepositoryLayout.java:                throw new IllegalArgumentException( "checksum algorithm has not been specified" );
./maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/layout/RepositoryLayout.java:                throw new IllegalArgumentException( "checksum location has not been specified" );
./maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/layout/RepositoryLayout.java:                throw new IllegalArgumentException( "checksum location must be relative" );
./maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/TransportTask.java:            throw new IllegalArgumentException( "resource location has not been specified" );
./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/ArtifactDefinition.java:            throw new IllegalArgumentException( "Need definition like 'gid:aid:ext:ver[:scope]', but was: "
./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/DependencyGraphParser.java:                    throw new IllegalArgumentException( "not enough substitutions to fill placeholders" );
./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/DependencyGraphParser.java:                    throw new IllegalArgumentException( "undefined reference " + reference );
./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/DependencyGraphParser.java:            throw new IllegalArgumentException( "dangling node: " + def );
./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/DependencyGraphParser.java:            throw new IllegalArgumentException( "inconsistent leveling (parent for level 0?): " + def );
./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/DependencyGraphParser.java:                throw new IllegalArgumentException( "bad version: " + e.getMessage(), e );
./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/IniArtifactDataReader.java:                throw new IllegalArgumentException( "Need definition like 'gid:aid:ext:ver[:scope]', but was: "
./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/NodeBuilder.java:                throw new IllegalArgumentException( "bad version: " + e.getMessage(), e );
./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/NodeDefinition.java:            throw new IllegalArgumentException( "bad syntax: " + def );
./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestDependencyGraphTransformationContext.java:            throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestDependencyGraphTransformationContext.java:            throw new IllegalArgumentException( "key must not be null" );
./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestVersionConstraint.java:            throw new IllegalArgumentException( "version range missing" );
./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestVersionConstraint.java:            throw new IllegalArgumentException( "version missing" );
./maven-resolver-transport-file/src/main/java/org/eclipse/aether/transport/file/FileTransporter.java:            throw new IllegalArgumentException( "Illegal resource path: " + path );
./maven-resolver-transport-wagon/src/main/java/org/eclipse/aether/internal/transport/wagon/PlexusWagonConfigurator.java:            throw new IllegalArgumentException( "plexus container has not been specified" );
./maven-resolver-transport-wagon/src/main/java/org/eclipse/aether/internal/transport/wagon/PlexusWagonConfigurator.java:            throw new IllegalArgumentException( "Unexpected configuration type: " + configuration.getClass().getName() );
./maven-resolver-transport-wagon/src/main/java/org/eclipse/aether/internal/transport/wagon/PlexusWagonProvider.java:            throw new IllegalArgumentException( "plexus container has not been specified" );
./maven-resolver-transport-wagon/src/test/java/org/eclipse/aether/transport/wagon/AbstractWagonTransporterTest.java:                throw new IllegalArgumentException( "Unknown wagon role: " + roleHint );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/artifact/DelegatingArtifact.java:            throw new IllegalArgumentException( "delegate artifact not specified" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/artifact/SubArtifact.java:            throw new IllegalArgumentException( "no artifact specified" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/concurrency/RunnableErrorForwarder.java:            throw new IllegalArgumentException( "runnable missing" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/filter/NotDependencyFilter.java:            throw new IllegalArgumentException( "no filter specified" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConflictResolver.java:            throw new IllegalArgumentException( "version selector not specified" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConflictResolver.java:            throw new IllegalArgumentException( "scope selector not specified" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConflictResolver.java:            throw new IllegalArgumentException( "scope deriver not specified" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConflictResolver.java:            throw new IllegalArgumentException( "optionality selector not specified" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/FilteringDependencyVisitor.java:            throw new IllegalArgumentException( "dependency visitor not specified" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/TreeDependencyVisitor.java:            throw new IllegalArgumentException( "no visitor delegate specified" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/ComponentAuthentication.java:            throw new IllegalArgumentException( "authentication key missing" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/ConservativeAuthenticationSelector.java:            throw new IllegalArgumentException( "no authentication selector specified" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/ConservativeProxySelector.java:            throw new IllegalArgumentException( "no proxy selector specified" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/DefaultProxySelector.java:            throw new IllegalArgumentException( "proxy not specified" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/SecretAuthentication.java:            throw new IllegalArgumentException( "authentication key missing" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/StringAuthentication.java:            throw new IllegalArgumentException( "authentication key missing" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/version/GenericVersionConstraint.java:            throw new IllegalArgumentException( "version range missing" );
./maven-resolver-util/src/main/java/org/eclipse/aether/util/version/GenericVersionConstraint.java:            throw new IllegalArgumentException( "version missing" );
./maven-resolver-util/src/test/java/org/eclipse/aether/util/graph/transformer/JavaScopeSelectorTest.java:            throw new IllegalArgumentException( "Illegal coordinates for child", e );
./maven-resolver-util/src/test/java/org/eclipse/aether/util/graph/transformer/JavaScopeSelectorTest.java:            throw new IllegalArgumentException( "Illegal coordinates for child", e );
./maven-resolver-util/src/test/java/org/eclipse/aether/util/graph/versions/AbstractVersionFilterTest.java:            throw new IllegalArgumentException( e );
./maven-resolver-util/src/test/java/org/eclipse/aether/util/version/UnionVersionRangeTest.java:            throw new IllegalArgumentException( e );
./maven-resolver-util/src/test/java/org/eclipse/aether/util/version/UnionVersionRangeTest.java:                throw new IllegalArgumentException( e );
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jira] [Created] (MRESOLVER-4) Use Commons Lang's Validate to intercept invalid input

Posted by Christian Schulte <cs...@schulte.it>.
Am 10/16/16 um 23:51 schrieb Stephen Connolly:
> Let's just go for Java 7... this is linked to core... if you are stuck on
> an older Java likely you can't upgrade Maven anyway

+1


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [jira] [Created] (MRESOLVER-4) Use Commons Lang's Validate to intercept invalid input

Posted by Stephen Connolly <st...@gmail.com>.
Let's just go for Java 7... this is linked to core... if you are stuck on
an older Java likely you can't upgrade Maven anyway

On Sunday 16 October 2016, Christian Schulte <cs...@schulte.it> wrote:

> Am 10/16/16 um 22:51 schrieb Michael Osipov:
> > Am 2016-10-16 um 22:48 schrieb Christian Schulte:
> >> Will the resolver be upgraded to Java 7? I would use 'java.util.Objects'
> >> then.
> >
> > I have the very same idea. I wouldn't mind using j.u.Objects instead of
> > o.a.c.l4.Validate.
> >
> > Is there any compelling reason not to switch to Java 7? NIO2 and
> > try-with-resources is nice.
> >
>
> +1 for Java 7
>
> Maven already is targeting Java 7. Depends on the other users of the
> resolver. If one of them still is not at Java 7, we will not be able to
> upgrade. I would not upgrade to Java 6 and keep it Java 5 then. So we go
> from 5 to 7 somewhen and skip 6.
>
> Regards,
> --
> Christian
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org <javascript:;>
> For additional commands, e-mail: dev-help@maven.apache.org <javascript:;>
>
>

-- 
Sent from my phone

Re: [jira] [Created] (MRESOLVER-4) Use Commons Lang's Validate to intercept invalid input

Posted by Christian Schulte <cs...@schulte.it>.
Am 10/16/16 um 22:51 schrieb Michael Osipov:
> Am 2016-10-16 um 22:48 schrieb Christian Schulte:
>> Will the resolver be upgraded to Java 7? I would use 'java.util.Objects'
>> then.
> 
> I have the very same idea. I wouldn't mind using j.u.Objects instead of 
> o.a.c.l4.Validate.
> 
> Is there any compelling reason not to switch to Java 7? NIO2 and 
> try-with-resources is nice.
> 

+1 for Java 7

Maven already is targeting Java 7. Depends on the other users of the
resolver. If one of them still is not at Java 7, we will not be able to
upgrade. I would not upgrade to Java 6 and keep it Java 5 then. So we go
from 5 to 7 somewhen and skip 6.

Regards,
-- 
Christian


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [jira] [Created] (MRESOLVER-4) Use Commons Lang's Validate to intercept invalid input

Posted by Michael Osipov <mi...@apache.org>.
Am 2016-10-16 um 22:48 schrieb Christian Schulte:
> Will the resolver be upgraded to Java 7? I would use 'java.util.Objects'
> then.

I have the very same idea. I wouldn't mind using j.u.Objects instead of 
o.a.c.l4.Validate.

Is there any compelling reason not to switch to Java 7? NIO2 and 
try-with-resources is nice.

Michael


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [jira] [Created] (MRESOLVER-4) Use Commons Lang's Validate to intercept invalid input

Posted by Christian Schulte <cs...@schulte.it>.
Will the resolver be upgraded to Java 7? I would use 'java.util.Objects'
then.

Am 10/16/16 um 22:30 schrieb Michael Osipov (JIRA):
> Michael Osipov created MRESOLVER-4:
> --------------------------------------
> 
>              Summary: Use Commons Lang's Validate to intercept invalid input
>                  Key: MRESOLVER-4
>                  URL: https://issues.apache.org/jira/browse/MRESOLVER-4
>              Project: Maven Resolver
>           Issue Type: Improvement
>     Affects Versions: Maven Artifact Resolver 1.2.0
>             Reporter: Michael Osipov
>             Assignee: Michael Osipov
>             Priority: Minor
>              Fix For: Maven Artifact Resolver 1.2.0
> 
> 
> In several spots of Maven Resolver IAE is thrown where an argument is null. This should be turned into NullPointerException since JDK adheres to is and the description of this exception indicates that and Effective Java does that too.
> 
> Most likely to be misused:
> {noformat}
> $ grep -r "throw new IllegalArgumentException" .
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java:            throw new IllegalArgumentException( "Bad artifact coordinates " + coords
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:            throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifactType.java:            throw new IllegalArgumentException( "no type id specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:            throw new IllegalArgumentException( "dependency collection request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultRepositorySystemSession.java:            throw new IllegalArgumentException( "repository system session not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:            throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:            throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/DefaultSessionData.java:            throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/deployment/DeployResult.java:            throw new IllegalArgumentException( "deploy request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/DefaultDependencyNode.java:            throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/graph/Dependency.java:            throw new IllegalArgumentException( "no artifact specified for dependency" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/installation/InstallResult.java:            throw new IllegalArgumentException( "install request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/metadata/DefaultMetadata.java:            throw new IllegalArgumentException( "metadata nature was not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:            throw new IllegalArgumentException( "repository system session missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:            throw new IllegalArgumentException( "authentication data key missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/AuthenticationContext.java:            throw new IllegalArgumentException( "authentication data key missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalArtifactResult.java:            throw new IllegalArgumentException( "local artifact request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/LocalMetadataResult.java:            throw new IllegalArgumentException( "local metadata request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java:                throw new IllegalArgumentException( "repository prototype missing" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:                throw new IllegalArgumentException( "session not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryEvent.java:                throw new IllegalArgumentException( "event type not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactDescriptorResult.java:            throw new IllegalArgumentException( "artifact descriptor request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/ArtifactResult.java:            throw new IllegalArgumentException( "resolution request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/DependencyResult.java:            throw new IllegalArgumentException( "dependency request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/MetadataResult.java:            throw new IllegalArgumentException( "metadata request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/VersionRangeResult.java:            throw new IllegalArgumentException( "version range request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/resolution/VersionResult.java:            throw new IllegalArgumentException( "version request has not been specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "session not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "transfer resource not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "event type not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "event type not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "request type not specified" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "number of transferred bytes cannot be negative" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferEvent.java:                throw new IllegalArgumentException( "number of transferred bytes cannot be negative" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/transfer/TransferResource.java:            throw new IllegalArgumentException( "resume offset cannot be negative" );
> ./maven-resolver-api/src/main/java/org/eclipse/aether/version/VersionRange.java:                throw new IllegalArgumentException( "version missing" );
> ./maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:                throw new IllegalArgumentException( "destination file has not been specified" );
> ./maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:                throw new IllegalArgumentException( "source file has not been specified" );
> ./maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnectorFactory.java:            throw new IllegalArgumentException( "transporter provider has not been specified" );
> ./maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnectorFactory.java:            throw new IllegalArgumentException( "repository layout provider has not been specified" );
> ./maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnectorFactory.java:            throw new IllegalArgumentException( "checksum policy provider has not been specified" );
> ./maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnectorFactory.java:            throw new IllegalArgumentException( "file processor has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/impl/DefaultServiceLocator.java:                throw new IllegalArgumentException( "service type not specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/impl/DefaultServiceLocator.java:                        throw new IllegalArgumentException( "service instance not specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/impl/DefaultServiceLocator.java:                throw new IllegalArgumentException( "implementation class not specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/impl/DefaultServiceLocator.java:            throw new IllegalArgumentException( "service type not specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "file processor has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "repository event dispatcher has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "version resolver has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "update check manager has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "repository connector provider has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "remote repository manager has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "sync context factory has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:            throw new IllegalArgumentException( "offline controller has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyCollector.java:            throw new IllegalArgumentException( "remote repository manager has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyCollector.java:            throw new IllegalArgumentException( "artifact descriptor reader has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyCollector.java:            throw new IllegalArgumentException( "version range resolver has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyGraphTransformationContext.java:            throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDependencyGraphTransformationContext.java:            throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "file processor has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "repository event dispatcher has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "repository connector provider has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "remote repository manager has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "update check manager has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "metadata generator factory has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "sync context factory has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultDeployer.java:            throw new IllegalArgumentException( "offline controller has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:            throw new IllegalArgumentException( "file processor has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:            throw new IllegalArgumentException( "repository event dispatcher has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:            throw new IllegalArgumentException( "metadata generator factory has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:            throw new IllegalArgumentException( "sync context factory has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:                throw new IllegalArgumentException( "Cannot install " + dstFile + " to same path" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultInstaller.java:                    throw new IllegalArgumentException( "Cannot install " + dstFile + " to same path" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultLocalRepositoryProvider.java:            throw new IllegalArgumentException( "Local repository manager factory has not been specified." );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java:            throw new IllegalArgumentException( "repository event dispatcher has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java:            throw new IllegalArgumentException( "update check manager has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java:            throw new IllegalArgumentException( "repository connector provider has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java:            throw new IllegalArgumentException( "remote repository manager has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java:            throw new IllegalArgumentException( "sync context factory has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultMetadataResolver.java:            throw new IllegalArgumentException( "offline controller has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRemoteRepositoryManager.java:            throw new IllegalArgumentException( "update policy analyzer has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRemoteRepositoryManager.java:            throw new IllegalArgumentException( "checksum policy provider has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java:            throw new IllegalArgumentException( "repository connector factory has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java:            throw new IllegalArgumentException( "remote repository has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryEventDispatcher.java:            throw new IllegalArgumentException( "repository listener has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryLayoutProvider.java:            throw new IllegalArgumentException( "layout factory has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryLayoutProvider.java:            throw new IllegalArgumentException( "remote repository has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "version resolver has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "version range resolver has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "artifact resolver has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "metadata resolver has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "artifact descriptor reader has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "dependency collector has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "installer has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "deployer has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "local repository provider has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "sync context factory has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "remote repository manager has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "dependency node or collect request missing" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( e.getMessage(), e );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:            throw new IllegalArgumentException( "Invalid repository system session: the session may not be null." );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositorySystem.java:        throw new IllegalArgumentException( "Invalid repository system session: " + name + " is not set." );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTransporterProvider.java:            throw new IllegalArgumentException( "transporter factory has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTransporterProvider.java:            throw new IllegalArgumentException( "remote repository has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java:            throw new IllegalArgumentException( "update policy analyzer has not been specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java:            throw new IllegalArgumentException( String.format( "The artifact '%s' has no file attached", artifact ) );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManager.java:            throw new IllegalArgumentException( String.format( "The metadata '%s' has no file attached", metadata ) );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/EnhancedLocalRepositoryManager.java:            throw new IllegalArgumentException( "artifact to register not specified" );
> ./maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/SimpleLocalRepositoryManager.java:            throw new IllegalArgumentException( "base directory has not been specified" );
> ./maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultDependencyCollectorTest.java:            throw new IllegalArgumentException( "Illegal coordinates for child", e );
> ./maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultDependencyCollectorTest.java:            throw new IllegalArgumentException( "Illegal coordinates for child", e );
> ./maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/layout/RepositoryLayout.java:                throw new IllegalArgumentException( "resource location must not have query parameters: " + location );
> ./maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/layout/RepositoryLayout.java:                throw new IllegalArgumentException( "resource location must not have a fragment: " + location );
> ./maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/layout/RepositoryLayout.java:                throw new IllegalArgumentException( "checksum algorithm has not been specified" );
> ./maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/layout/RepositoryLayout.java:                throw new IllegalArgumentException( "checksum location has not been specified" );
> ./maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/layout/RepositoryLayout.java:                throw new IllegalArgumentException( "checksum location must be relative" );
> ./maven-resolver-spi/src/main/java/org/eclipse/aether/spi/connector/transport/TransportTask.java:            throw new IllegalArgumentException( "resource location has not been specified" );
> ./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/ArtifactDefinition.java:            throw new IllegalArgumentException( "Need definition like 'gid:aid:ext:ver[:scope]', but was: "
> ./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/DependencyGraphParser.java:                    throw new IllegalArgumentException( "not enough substitutions to fill placeholders" );
> ./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/DependencyGraphParser.java:                    throw new IllegalArgumentException( "undefined reference " + reference );
> ./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/DependencyGraphParser.java:            throw new IllegalArgumentException( "dangling node: " + def );
> ./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/DependencyGraphParser.java:            throw new IllegalArgumentException( "inconsistent leveling (parent for level 0?): " + def );
> ./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/DependencyGraphParser.java:                throw new IllegalArgumentException( "bad version: " + e.getMessage(), e );
> ./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/IniArtifactDataReader.java:                throw new IllegalArgumentException( "Need definition like 'gid:aid:ext:ver[:scope]', but was: "
> ./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/NodeBuilder.java:                throw new IllegalArgumentException( "bad version: " + e.getMessage(), e );
> ./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/NodeDefinition.java:            throw new IllegalArgumentException( "bad syntax: " + def );
> ./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestDependencyGraphTransformationContext.java:            throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestDependencyGraphTransformationContext.java:            throw new IllegalArgumentException( "key must not be null" );
> ./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestVersionConstraint.java:            throw new IllegalArgumentException( "version range missing" );
> ./maven-resolver-test-util/src/main/java/org/eclipse/aether/internal/test/util/TestVersionConstraint.java:            throw new IllegalArgumentException( "version missing" );
> ./maven-resolver-transport-file/src/main/java/org/eclipse/aether/transport/file/FileTransporter.java:            throw new IllegalArgumentException( "Illegal resource path: " + path );
> ./maven-resolver-transport-wagon/src/main/java/org/eclipse/aether/internal/transport/wagon/PlexusWagonConfigurator.java:            throw new IllegalArgumentException( "plexus container has not been specified" );
> ./maven-resolver-transport-wagon/src/main/java/org/eclipse/aether/internal/transport/wagon/PlexusWagonConfigurator.java:            throw new IllegalArgumentException( "Unexpected configuration type: " + configuration.getClass().getName() );
> ./maven-resolver-transport-wagon/src/main/java/org/eclipse/aether/internal/transport/wagon/PlexusWagonProvider.java:            throw new IllegalArgumentException( "plexus container has not been specified" );
> ./maven-resolver-transport-wagon/src/test/java/org/eclipse/aether/transport/wagon/AbstractWagonTransporterTest.java:                throw new IllegalArgumentException( "Unknown wagon role: " + roleHint );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/artifact/DelegatingArtifact.java:            throw new IllegalArgumentException( "delegate artifact not specified" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/artifact/SubArtifact.java:            throw new IllegalArgumentException( "no artifact specified" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/concurrency/RunnableErrorForwarder.java:            throw new IllegalArgumentException( "runnable missing" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/filter/NotDependencyFilter.java:            throw new IllegalArgumentException( "no filter specified" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConflictResolver.java:            throw new IllegalArgumentException( "version selector not specified" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConflictResolver.java:            throw new IllegalArgumentException( "scope selector not specified" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConflictResolver.java:            throw new IllegalArgumentException( "scope deriver not specified" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/transformer/ConflictResolver.java:            throw new IllegalArgumentException( "optionality selector not specified" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/FilteringDependencyVisitor.java:            throw new IllegalArgumentException( "dependency visitor not specified" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/graph/visitor/TreeDependencyVisitor.java:            throw new IllegalArgumentException( "no visitor delegate specified" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/ComponentAuthentication.java:            throw new IllegalArgumentException( "authentication key missing" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/ConservativeAuthenticationSelector.java:            throw new IllegalArgumentException( "no authentication selector specified" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/ConservativeProxySelector.java:            throw new IllegalArgumentException( "no proxy selector specified" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/DefaultProxySelector.java:            throw new IllegalArgumentException( "proxy not specified" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/SecretAuthentication.java:            throw new IllegalArgumentException( "authentication key missing" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/repository/StringAuthentication.java:            throw new IllegalArgumentException( "authentication key missing" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/version/GenericVersionConstraint.java:            throw new IllegalArgumentException( "version range missing" );
> ./maven-resolver-util/src/main/java/org/eclipse/aether/util/version/GenericVersionConstraint.java:            throw new IllegalArgumentException( "version missing" );
> ./maven-resolver-util/src/test/java/org/eclipse/aether/util/graph/transformer/JavaScopeSelectorTest.java:            throw new IllegalArgumentException( "Illegal coordinates for child", e );
> ./maven-resolver-util/src/test/java/org/eclipse/aether/util/graph/transformer/JavaScopeSelectorTest.java:            throw new IllegalArgumentException( "Illegal coordinates for child", e );
> ./maven-resolver-util/src/test/java/org/eclipse/aether/util/graph/versions/AbstractVersionFilterTest.java:            throw new IllegalArgumentException( e );
> ./maven-resolver-util/src/test/java/org/eclipse/aether/util/version/UnionVersionRangeTest.java:            throw new IllegalArgumentException( e );
> ./maven-resolver-util/src/test/java/org/eclipse/aether/util/version/UnionVersionRangeTest.java:                throw new IllegalArgumentException( e );
> {noformat}
> 
> 
> 
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org