You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/15 14:25:17 UTC

[GitHub] [arrow] westonpace commented on a diff in pull request #12826: ARROW-15260: [R] open_dataset - add file_name as column

westonpace commented on code in PR #12826:
URL: https://github.com/apache/arrow/pull/12826#discussion_r922218735


##########
r/src/compute-exec.cpp:
##########
@@ -146,20 +146,12 @@ std::shared_ptr<compute::ExecNode> ExecNode_Scan(
 
   options->dataset_schema = dataset->schema();
 
-  // ScanNode needs the filter to do predicate pushdown and skip partitions
-  options->filter = ValueOrStop(filter->Bind(*dataset->schema()));

Review Comment:
   Perhaps:
   ```
   options->filter = *filter
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org