You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by dk...@apache.org on 2010/10/20 21:25:45 UTC
svn commit: r1025683 -
/cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/DigestAuthSupplier.java
Author: dkulp
Date: Wed Oct 20 19:25:45 2010
New Revision: 1025683
URL: http://svn.apache.org/viewvc?rev=1025683&view=rev
Log:
[CXF-3073] Switch to instance var for md5 digest and sync it properly
Modified:
cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/DigestAuthSupplier.java
Modified: cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/DigestAuthSupplier.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/DigestAuthSupplier.java?rev=1025683&r1=1025682&r2=1025683&view=diff
==============================================================================
--- cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/DigestAuthSupplier.java (original)
+++ cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/DigestAuthSupplier.java Wed Oct 20 19:25:45 2010
@@ -40,19 +40,21 @@ public class DigestAuthSupplier extends
private static final char[] HEXADECIMAL = {
'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f'
};
- private static final MessageDigest MD5_HELPER;
- static {
+
+ final MessageDigest md5Helper;
+ Map<URL, DigestInfo> authInfo = new ConcurrentHashMap<URL, DigestInfo>();
+
+ public DigestAuthSupplier() {
MessageDigest md = null;
try {
md = MessageDigest.getInstance("MD5");
} catch (NoSuchAlgorithmException e) {
md = null;
}
- MD5_HELPER = md;
+ md5Helper = md;
}
-
- Map<URL, DigestInfo> authInfo = new ConcurrentHashMap<URL, DigestInfo>();
-
+
+
/**
* {@inheritDoc}
* With digest, the nonce could expire and thus a rechallenge will be issued.
@@ -243,9 +245,13 @@ public class DigestAuthSupplier extends
}
- public static String createCnonce() throws UnsupportedEncodingException {
+ public String createCnonce() throws UnsupportedEncodingException {
String cnonce = Long.toString(System.currentTimeMillis());
- return encode(MD5_HELPER.digest(cnonce.getBytes("US-ASCII")));
+ byte[] bytes = cnonce.getBytes("US-ASCII");
+ synchronized (md5Helper) {
+ bytes = md5Helper.digest(bytes);
+ }
+ return encode(bytes);
}
/**