[jira] [Commented] (CASSANDRA-17054) v5+ protocol does not clean up client warnings, which causes leaking the state to prior versions

["David Capwell (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-17054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432671#comment-17432671 ] 

David Capwell commented on CASSANDRA-17054:
-------------------------------------------

To validate the test does fail without the patch, revert

{code}
src/java/org/apache/cassandra/transport/Dispatcher.java
src/java/org/apache/cassandra/transport/InitialConnectionHandler.java
{code}

> v5+ protocol does not clean up client warnings, which causes leaking the state to prior versions
> ------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17054
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17054
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Messaging/Client
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>             Fix For: 4.0.x, 4.x
>
>
> If you perform a query in v5, this will cause the STARTUP message to be handled in the netty thread, but the way this is done is by calling an internal API to dispatcher which requires the caller to clean up; but we do not clean up; at this point the netty thread will have a ClientWarn state populated.  If you now perform the same query again, but with the v3 protocol, this will pick up the state and try to serialize it, causing a client error (in java as java rejects the output from the server) saying that v3 may not have client warnings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org