You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ma...@apache.org on 2020/10/20 02:59:40 UTC

[lucene-solr] 02/02: @1038 Enable test.

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl_dev
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git

commit 84c4e1eb05ad90a5177a7be633609f2b26a3bc4e
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Mon Oct 19 21:59:12 2020 -0500

    @1038 Enable test.
---
 solr/core/src/test/org/apache/solr/core/TestSolrXml.java | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/solr/core/src/test/org/apache/solr/core/TestSolrXml.java b/solr/core/src/test/org/apache/solr/core/TestSolrXml.java
index bc980b8..7960782 100644
--- a/solr/core/src/test/org/apache/solr/core/TestSolrXml.java
+++ b/solr/core/src/test/org/apache/solr/core/TestSolrXml.java
@@ -150,7 +150,6 @@ public class TestSolrXml extends SolrTestCaseJ4 {
     assertEquals(ok, cfg.getTransientCacheSize());
   }
 
-  @Ignore // nocommir - still evaluating these, they seem expensive, may be okay after other fixes
   public void testMultiCloudSectionError() {
     String solrXml = "<solr>"
       + "<solrcloud><bool name=\"genericCoreNodeNames\">true</bool></solrcloud>"
@@ -161,7 +160,6 @@ public class TestSolrXml extends SolrTestCaseJ4 {
     SolrXmlConfig.fromString(solrHome, solrXml); // return not used, only for validation
   }
 
-  @Ignore // nocommir - still evaluating these, they seem expensive, may be okay after other fixes
   public void testMultiLoggingSectionError() {
     String solrXml = "<solr>"
       + "<logging><str name=\"class\">foo</str></logging>"
@@ -172,7 +170,6 @@ public class TestSolrXml extends SolrTestCaseJ4 {
     SolrXmlConfig.fromString(solrHome, solrXml); // return not used, only for validation
   }
 
-  @Ignore // nocommir - still evaluating these, they seem expensive, may be okay after other fixes
   public void testMultiLoggingWatcherSectionError() {
     String solrXml = "<solr><logging>"
       + "<watcher><int name=\"threshold\">42</int></watcher>"
@@ -290,7 +287,7 @@ public class TestSolrXml extends SolrTestCaseJ4 {
     SolrXmlConfig.fromString(solrHome, solrXml); // return not used, only for validation
   }
 
-  @Ignore
+  @Ignore // nocommit - this check does not seem to be enabled currently
   public void testFailAtConfigParseTimeWhenSolrConfigParamsAreDuplicated() {
     String v1 = ""+random().nextInt();
     String v2 = ""+random().nextInt();
@@ -328,7 +325,6 @@ public class TestSolrXml extends SolrTestCaseJ4 {
     SolrXmlConfig.fromString(solrHome, "<solr><solrcloud><str name=\"host\">host</str><int name=\"hostPort\">8983</int></solrcloud></solr>");
   }
 
-  @Ignore // nocommir - still evaluating these, they seem expensive, may be okay after other fixes
   public void testMultiBackupSectionError() {
     String solrXml = "<solr><backup></backup><backup></backup></solr>";
     expectedException.expect(SolrException.class);