[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #1381: SOLR-14364: LTR SolrFeature fq improvements
URL: https://github.com/apache/lucene-solr/pull/1381#discussion_r401310167
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/search/grouping/CommandHandler.java
 ##########
 @@ -228,12 +226,8 @@ private void searchWithTimeLimiter(Query query,
       collector = MultiCollector.wrap(collector, hitCountCollector);
     }
 
-    if (filter.filter != null) {
-      query = new BooleanQuery.Builder()
-          .add(query, Occur.MUST)
-          .add(filter.filter, Occur.FILTER)
-          .build();
-    }
+    query = QueryUtils.combineQueryAndFilter(query, filter.filter);
 
 Review comment:
   I wouldn't define combineQueryAndFilter by who uses it to reverse engineer how it might work; it has its own javadocs.  It behaves the same no matter who calls it.  Do you think it's defaults are counterintuitive?
   
   BTW I think it's a mistake that Solr's 'q' effectively defaults to semantics of MatchNoDocsQuery.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org