You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by ki...@apache.org on 2022/02/25 14:57:21 UTC
[incubator-seatunnel] branch dev updated: [Improve#1319] [code style] config module enables checkstyle (#1320)
This is an automated email from the ASF dual-hosted git repository.
kirs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new 0a3b6f3 [Improve#1319] [code style] config module enables checkstyle (#1320)
0a3b6f3 is described below
commit 0a3b6f3a803b4b7edff41696c7c724ea9f96281b
Author: Benedict Jin <as...@apache.org>
AuthorDate: Fri Feb 25 22:57:12 2022 +0800
[Improve#1319] [code style] config module enables checkstyle (#1320)
* Remove the skip=true configuration in maven-checkstyle-plugin for seatunnel-config-shade module
---
seatunnel-config/seatunnel-config-shade/pom.xml | 9 ---------
.../seatunnel/shade/com/typesafe/config/impl/ConfigNodePath.java | 1 +
.../src/test/java/org/apache/seatunnel/config/CompleteTest.java | 1 +
.../test/java/org/apache/seatunnel/config/ConfigFactoryTest.java | 1 +
4 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/seatunnel-config/seatunnel-config-shade/pom.xml b/seatunnel-config/seatunnel-config-shade/pom.xml
index b55166c..c9d9159 100644
--- a/seatunnel-config/seatunnel-config-shade/pom.xml
+++ b/seatunnel-config/seatunnel-config-shade/pom.xml
@@ -54,15 +54,6 @@
<finalName>${project.artifactId}-${project.version}</finalName>
<plugins>
-
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-checkstyle-plugin</artifactId>
- <configuration>
- <skip>true</skip>
- </configuration>
- </plugin>
-
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
diff --git a/seatunnel-config/seatunnel-config-shade/src/main/java/org/apache/seatunnel/shade/com/typesafe/config/impl/ConfigNodePath.java b/seatunnel-config/seatunnel-config-shade/src/main/java/org/apache/seatunnel/shade/com/typesafe/config/impl/ConfigNodePath.java
index 1502719..d917d84 100644
--- a/seatunnel-config/seatunnel-config-shade/src/main/java/org/apache/seatunnel/shade/com/typesafe/config/impl/ConfigNodePath.java
+++ b/seatunnel-config/seatunnel-config-shade/src/main/java/org/apache/seatunnel/shade/com/typesafe/config/impl/ConfigNodePath.java
@@ -1,6 +1,7 @@
/*
* Copyright (C) 2011-2012 Typesafe Inc. <http://typesafe.com>
*/
+
package org.apache.seatunnel.shade.com.typesafe.config.impl;
import org.apache.seatunnel.shade.com.typesafe.config.ConfigException;
diff --git a/seatunnel-config/seatunnel-config-shade/src/test/java/org/apache/seatunnel/config/CompleteTest.java b/seatunnel-config/seatunnel-config-shade/src/test/java/org/apache/seatunnel/config/CompleteTest.java
index 371776c..88b26b9 100644
--- a/seatunnel-config/seatunnel-config-shade/src/test/java/org/apache/seatunnel/config/CompleteTest.java
+++ b/seatunnel-config/seatunnel-config-shade/src/test/java/org/apache/seatunnel/config/CompleteTest.java
@@ -22,6 +22,7 @@ import org.apache.seatunnel.config.utils.FileUtils;
import org.apache.seatunnel.shade.com.typesafe.config.Config;
import org.apache.seatunnel.shade.com.typesafe.config.ConfigFactory;
import org.apache.seatunnel.shade.com.typesafe.config.ConfigResolveOptions;
+
import org.junit.Assert;
import org.junit.Test;
diff --git a/seatunnel-config/seatunnel-config-shade/src/test/java/org/apache/seatunnel/config/ConfigFactoryTest.java b/seatunnel-config/seatunnel-config-shade/src/test/java/org/apache/seatunnel/config/ConfigFactoryTest.java
index e41c2a2..c0250e6 100644
--- a/seatunnel-config/seatunnel-config-shade/src/test/java/org/apache/seatunnel/config/ConfigFactoryTest.java
+++ b/seatunnel-config/seatunnel-config-shade/src/test/java/org/apache/seatunnel/config/ConfigFactoryTest.java
@@ -21,6 +21,7 @@ import org.apache.seatunnel.config.utils.FileUtils;
import org.apache.seatunnel.shade.com.typesafe.config.Config;
import org.apache.seatunnel.shade.com.typesafe.config.ConfigFactory;
+
import org.junit.Assert;
import org.junit.Test;