You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/17 04:43:14 UTC
[GitHub] [flink] zhuzhurk commented on a change in pull request #11783:
[FLINK-17181][runtime] Drop generic Types in SchedulingTopology Interface
zhuzhurk commented on a change in pull request #11783: [FLINK-17181][runtime] Drop generic Types in SchedulingTopology Interface
URL: https://github.com/apache/flink/pull/11783#discussion_r409988394
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/partitionrelease/RegionPartitionReleaseStrategy.java
##########
@@ -174,9 +174,9 @@ private boolean isRegionOfVertexFinished(final ExecutionVertexID executionVertex
public static class Factory implements PartitionReleaseStrategy.Factory {
@Override
- public PartitionReleaseStrategy createInstance(final SchedulingTopology<?, ?> schedulingStrategy) {
+ public PartitionReleaseStrategy createInstance(final SchedulingTopology schedulingStrategy) {
- final Set<? extends Set<? extends SchedulingExecutionVertex<?, ?>>> distinctRegions =
+ final Set<? extends Set<? extends SchedulingExecutionVertex>> distinctRegions =
Review comment:
Now it can be simplified to `Set<Set<SchedulingExecutionVertex>>`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services