[jira] [Commented] (ARTEMIS-949) Prevent Openwire from closing consumer twice

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857605#comment-15857605 ] 

ASF GitHub Bot commented on ARTEMIS-949:
----------------------------------------

GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/998

    ARTEMIS-949 Prevent Openwire from closing consumer twice

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis master_949

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/998.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #998
    
----
commit 1a3fdd0916c3fb9af1eca283b717c1e49d6fbabb
Author: Howard Gao <ho...@gmail.com>
Date:   2017-02-08T07:57:43Z

    ARTEMIS-949 Prevent Openwire from closing consumer twice

----


> Prevent Openwire from closing consumer twice
> --------------------------------------------
>
>                 Key: ARTEMIS-949
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-949
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: OpenWire
>    Affects Versions: 1.5.2
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>             Fix For: 2.0.0
>
>
> It is possible that in some multi-thread cases an openwire client sends a disconnet command followed by a 'remove consumer' command, which causes the broker to call consumer close twice. This can cause problem in calculating consumer count on a remote binding by sending "CONSUMER_REMOVED" notification twice, resulting in negative consumer count.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)