[GitHub] [dubbo] finefuture commented on a diff in pull request #12329: optimize performance for MetricsFilter

["finefuture (via GitHub)" <gi...@apache.org>]

finefuture commented on code in PR #12329:
URL: https://github.com/apache/dubbo/pull/12329#discussion_r1197727446


##########
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/listener/AbstractMetricsListener.java:
##########
@@ -20,16 +20,19 @@
 import org.apache.dubbo.common.utils.ReflectionUtils;
 import org.apache.dubbo.metrics.event.MetricsEvent;
 
-import java.util.List;
+import java.util.HashMap;
+import java.util.Map;
 
 public abstract class AbstractMetricsListener<E extends MetricsEvent> implements MetricsListener<E> {
 
+    private final Map<Class<?>, Boolean> eventMatchCache = new HashMap<>();

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org