[jira] [Commented] (KAFKA-5034) Connect workers don't discover new Connector Plugins without Restart

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446393#comment-16446393 ] 

ASF GitHub Bot commented on KAFKA-5034:
---------------------------------------

C0urante opened a new pull request #4905: KAFKA-5034: Enable plugins to be added to the plugin path at runtime
URL: https://github.com/apache/kafka/pull/4905
 
 
   Each directory in the plugin.path is monitored for file system changes via a daemon thread, and when a change is detected that appears to correspond to a plugin creation (e.g., a directory or archive file is created), the DelegatingClassLoader is alerted and scans the location for new plugins to register.
   
   Plugin removals currently only result in a warning, since once they are loaded by the DelegatingClassLoader, deletion of the corresponding .class, .zip, or .jar files does not remove them from the class loader.
   
   Testing involves creating a directory, populating it with several fake plugins, and watching it with a `PluginPathDirectoryListener`. At that point, several more fake plugins are created, and it is verified that their creation has been detected by the listener. Afterward, some fake plugins are deleted, and it is verified that their deletion has been detected by the listener. A "red herring" file is also created and deleted during the test, and it is verified that that file is not acknowledged by the listener. All current plugin formats are included in the test (directory, JAR file, and ZIP file).
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Connect workers don't discover new Connector Plugins without Restart
> --------------------------------------------------------------------
>
>                 Key: KAFKA-5034
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5034
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>            Reporter: Gwen Shapira
>            Priority: Major
>
> If I want to add a new Connector Plugin to a running distributed Connect cluster, I need to copy the JAR to the classpath and then restart all the workers so they will pick up the new plugin before I can create a connector.
> This is both un-intuitive (most modern up can pick up changes dynamically) and can get difficult when a connect cluster is shared between teams.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)