You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/04 13:48:09 UTC

[GitHub] [airflow] tirkarthi commented on a change in pull request #5533: [AIRFLOW-4895] Import Iterable from collections.abc to fix DeprecationWarning in Python 3.7

tirkarthi commented on a change in pull request #5533: [AIRFLOW-4895] Import Iterable from collections.abc to fix DeprecationWarning in Python 3.7
URL: https://github.com/apache/airflow/pull/5533#discussion_r300406900
 
 

 ##########
 File path: airflow/utils/helpers.py
 ##########
 @@ -23,7 +23,12 @@
 
 from datetime import datetime
 from functools import reduce
-from collections import Iterable
+try:
+    # Fix Python > 3.7 deprecation
+    from collections.abc import Iterable
+except ImportError:
+    # Preserve Python < 3.3 compatibility
 
 Review comment:
   Thanks, it's also present in 1.10.x branch. The fix was based on https://issues.apache.org/jira/browse/AIRFLOW-3009 where similar problem was fixed in master and also seemed to be backported to 1.10.3.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services