You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oozie.apache.org by tu...@apache.org on 2013/04/19 00:54:42 UTC

svn commit: r1469625 - in /oozie/trunk: ./ hadooplibs/hadoop-0.23/ hadooplibs/hadoop-distcp-0.23/ hadooplibs/hadoop-test-0.23/ hbaselibs/ hbaselibs/hbase-0.94/ hcataloglibs/ hcataloglibs/hcatalog-0.5/ hcataloglibs/hcatalog-0.6/ sharelib/hcatalog/ workf...

Author: tucu
Date: Thu Apr 18 22:54:42 2013
New Revision: 1469625

URL: http://svn.apache.org/r1469625
Log:
OOZIE-1083 WFGEN Help -> About dialog box (jaoki via tucu)

Added:
    oozie/trunk/workflowgenerator/src/test/
    oozie/trunk/workflowgenerator/src/test/java/
    oozie/trunk/workflowgenerator/src/test/java/org/
    oozie/trunk/workflowgenerator/src/test/java/org/apache/
    oozie/trunk/workflowgenerator/src/test/java/org/apache/oozie/
    oozie/trunk/workflowgenerator/src/test/java/org/apache/oozie/tools/
    oozie/trunk/workflowgenerator/src/test/java/org/apache/oozie/tools/workflowgenerator/
    oozie/trunk/workflowgenerator/src/test/java/org/apache/oozie/tools/workflowgenerator/client/
    oozie/trunk/workflowgenerator/src/test/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGeneratorTest.java
Modified:
    oozie/trunk/hadooplibs/hadoop-0.23/   (props changed)
    oozie/trunk/hadooplibs/hadoop-distcp-0.23/   (props changed)
    oozie/trunk/hadooplibs/hadoop-test-0.23/   (props changed)
    oozie/trunk/hbaselibs/   (props changed)
    oozie/trunk/hbaselibs/hbase-0.94/   (props changed)
    oozie/trunk/hcataloglibs/   (props changed)
    oozie/trunk/hcataloglibs/hcatalog-0.5/   (props changed)
    oozie/trunk/hcataloglibs/hcatalog-0.6/   (props changed)
    oozie/trunk/release-log.txt
    oozie/trunk/sharelib/hcatalog/   (props changed)
    oozie/trunk/workflowgenerator/   (props changed)
    oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGenerator.java

Propchange: oozie/trunk/hadooplibs/hadoop-0.23/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Thu Apr 18 22:54:42 2013
@@ -0,0 +1 @@
+target

Propchange: oozie/trunk/hadooplibs/hadoop-distcp-0.23/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Thu Apr 18 22:54:42 2013
@@ -0,0 +1 @@
+target

Propchange: oozie/trunk/hadooplibs/hadoop-test-0.23/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Thu Apr 18 22:54:42 2013
@@ -0,0 +1 @@
+target

Propchange: oozie/trunk/hbaselibs/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Thu Apr 18 22:54:42 2013
@@ -0,0 +1 @@
+target

Propchange: oozie/trunk/hbaselibs/hbase-0.94/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Thu Apr 18 22:54:42 2013
@@ -0,0 +1 @@
+target

Propchange: oozie/trunk/hcataloglibs/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Thu Apr 18 22:54:42 2013
@@ -0,0 +1 @@
+target

Propchange: oozie/trunk/hcataloglibs/hcatalog-0.5/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Thu Apr 18 22:54:42 2013
@@ -0,0 +1 @@
+target

Propchange: oozie/trunk/hcataloglibs/hcatalog-0.6/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Thu Apr 18 22:54:42 2013
@@ -0,0 +1 @@
+target

Modified: oozie/trunk/release-log.txt
URL: http://svn.apache.org/viewvc/oozie/trunk/release-log.txt?rev=1469625&r1=1469624&r2=1469625&view=diff
==============================================================================
--- oozie/trunk/release-log.txt (original)
+++ oozie/trunk/release-log.txt Thu Apr 18 22:54:42 2013
@@ -1,5 +1,6 @@
 -- Oozie 4.1.0 release (trunk - unreleased)
 
+OOZIE-1083 WFGEN Help -> About dialog box (jaoki via tucu)
 OOZIE-670 Merge addtowar and oozie-setup scripts into one (bowenzhangusa via tucu)
 OOZIE-1326 sharelib tests failing saying error on fork after OOZIE-1311 refactor (rohini via rkanter)
 OOZIE-1235 Client API for retrieving topic and jms connection related details (virag)

Propchange: oozie/trunk/sharelib/hcatalog/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Thu Apr 18 22:54:42 2013
@@ -0,0 +1 @@
+target

Propchange: oozie/trunk/workflowgenerator/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Thu Apr 18 22:54:42 2013
@@ -0,0 +1 @@
+target

Modified: oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGenerator.java
URL: http://svn.apache.org/viewvc/oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGenerator.java?rev=1469625&r1=1469624&r2=1469625&view=diff
==============================================================================
--- oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGenerator.java (original)
+++ oozie/trunk/workflowgenerator/src/main/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGenerator.java Thu Apr 18 22:54:42 2013
@@ -61,6 +61,8 @@ import com.google.gwt.user.client.ui.*;
  */
 public class OozieWorkflowGenerator implements EntryPoint {
 
+    private static final int ZINDEX_FRONT_OF_GRID = 10;
+
     private PickupDragController dragController;
     private OozieDiagramController controller;
     private Panel propPanel;
@@ -551,7 +553,44 @@ public class OozieWorkflowGenerator impl
         helpMenu.addItem("Documentation", openOozieTopPageComman);
         helpMenu.addItem("Online Help", openOozieTopPageComman);
 
-        helpMenu.addItem("About", cmd);
+
+        Command aboutCommand = new Command() {
+            @Override
+            public void execute() {
+                // Dialogbox
+                final DialogBox d = new DialogBox(false, true);
+                d.setGlassEnabled(true);
+                d.setText("About Oozie Workflow Generator");
+                d.center();
+
+                // Set this to workaround the grid z-index issue https://issues.apache.org/jira/browse/OOZIE-1081
+                d.getElement().getStyle().setZIndex(ZINDEX_FRONT_OF_GRID);
+
+                // About text
+                VerticalPanel vpanel = new VerticalPanel();
+                vpanel.setHorizontalAlignment(HasHorizontalAlignment.ALIGN_CENTER);
+                vpanel.setSpacing(10);
+                vpanel.setWidth("150");
+                vpanel.add(new Label("Oozie Workflow Generator"));
+                vpanel.add(new Label("Version 3.4.0-SNAPSHOT")); // TODO how to get a version number from pom?
+
+                // OK button to close
+                Button ok = new Button("OK");
+                ok.addClickHandler(new ClickHandler(){
+                    @Override
+                    public void onClick(ClickEvent event) {
+                        d.hide();
+                    }
+
+                });
+
+                vpanel.add(ok);
+                d.setWidget(vpanel);
+                d.show();
+
+            }
+        };
+        helpMenu.addItem("About", aboutCommand);
 
         MenuBar menu = new MenuBar();
         menu.addItem("File", fileMenu);

Added: oozie/trunk/workflowgenerator/src/test/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGeneratorTest.java
URL: http://svn.apache.org/viewvc/oozie/trunk/workflowgenerator/src/test/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGeneratorTest.java?rev=1469625&view=auto
==============================================================================
--- oozie/trunk/workflowgenerator/src/test/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGeneratorTest.java (added)
+++ oozie/trunk/workflowgenerator/src/test/java/org/apache/oozie/tools/workflowgenerator/client/OozieWorkflowGeneratorTest.java Thu Apr 18 22:54:42 2013
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.oozie.tools.workflowgenerator.client;
+
+import junit.framework.TestCase;
+
+import org.junit.Test;
+
+public class OozieWorkflowGeneratorTest extends TestCase{
+
+    //TODO very first test of wfgen and does not do much.
+    @Test
+    public void test1() {
+        OozieWorkflowGenerator entry = new OozieWorkflowGenerator();
+        assertTrue(entry instanceof OozieWorkflowGenerator);
+    }
+
+}