You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2020/02/10 01:33:21 UTC

Review Request 72102: ATLAS-3611: updated AtlasEntityDef with addition of read-only field namespaceAttributeDefs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72102/
-----------------------------------------------------------

Review request for atlas, Ashutosh Mestry, keval bhatt, Mandar Ambawane, mayank jain, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3611
    https://issues.apache.org/jira/browse/ATLAS-3611


Repository: atlas


Description
-------

added read-only field AtlasEntityDef.namespaceAttributes and populate it while resolving references in type-registry


Diffs
-----

  intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 14b3f03b0 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 02d6d58f1 


Diff: https://reviews.apache.org/r/72102/diff/1/


Testing
-------

- added couple of namespaces having attributes, and verified that the attributes are added to namespaceAttributes in relevant AtlasEntityDef.


Thanks,

Madhan Neethiraj


Re: Review Request 72102: ATLAS-3611: updated AtlasEntityDef with addition of read-only field namespaceAttributeDefs

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72102/#review219537
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On Feb. 10, 2020, 1:33 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72102/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2020, 1:33 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Mandar Ambawane, mayank jain, Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3611
>     https://issues.apache.org/jira/browse/ATLAS-3611
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> added read-only field AtlasEntityDef.namespaceAttributes and populate it while resolving references in type-registry
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 14b3f03b0 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 02d6d58f1 
> 
> 
> Diff: https://reviews.apache.org/r/72102/diff/1/
> 
> 
> Testing
> -------
> 
> - added couple of namespaces having attributes, and verified that the attributes are added to namespaceAttributes in relevant AtlasEntityDef.
> - pre-commit tests run: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1624/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>