[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8166: [feature][dashboard] Show/hide filter indicator on the applicable charts when filter options are open/close

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8166: [feature][dashboard] Show/hide filter indicator on the applicable charts when filter options are open/close
URL: https://github.com/apache/incubator-superset/pull/8166#discussion_r321381273
 
 

 ##########
 File path: superset/assets/src/dashboard/components/FilterIndicator.jsx
 ##########
 @@ -56,12 +62,14 @@ class FilterIndicator extends React.PureComponent {
     return (
       <FilterTooltipWrapper tooltip={filterTooltip}>
         <div
-          className="filter-indicator"
+          className={`filter-indicator ${
+            isFilterFieldActive ? 'isFilterFieldActive' : ''
 
 Review comment:
   this css class naming seems inconsistent, is there anything wrong with just adding on the class `active` along with `filter-indicator`? Or at least using dash case to match `filter-indicator`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org