[jira] [Commented] (CASSANDRA-15725) Add support for adding custom Verbs

["David Capwell (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-15725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102798#comment-17102798 ] 

David Capwell commented on CASSANDRA-15725:
-------------------------------------------

Overall LGTM.  I attached a patch to make sure we detect all potential id conflicts (left 3 commented out verbs for testing).

I also tested out a 3.x custom verb upgrade.  if custom verbs exist which don't map to the new ID format, and backwards compatibility is needed, the verb can define a pre40 verb with the old id, and the custom one can override org.apache.cassandra.net.Verb#toPre40Verb to point to it; this allows migration.

> Add support for adding custom Verbs
> -----------------------------------
>
>                 Key: CASSANDRA-15725
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15725
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Messaging/Internode
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Normal
>             Fix For: 4.0-alpha
>
>         Attachments: feedback_15725.patch
>
>
> It should be possible to safely add custom/internal Verbs - without risking conflicts when new  ones are added.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org