[GitHub] [iceberg] rdblue commented on a change in pull request #3276: Parquet: avoid premature closing of FSDataInputStream object

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3276:
URL: https://github.com/apache/iceberg/pull/3276#discussion_r731993488



##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java
##########
@@ -178,7 +180,8 @@ public long getLength() throws IOException {
 
     @Override
     public SeekableInputStream newStream() throws IOException {
-      return stream(file.newStream());
+      icebergHadoopStream = file.newStream();
+      return stream(icebergHadoopStream);

Review comment:
       This doesn't look correct to me. The `InputFile` is a factory interface and is not responsible for keeping references to the streams that are created.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org