[GitHub] [calcite] michaelmior commented on a change in pull request #1319: [CALCITE-3195] Handle UDF that throws checked exceptions in enumerable code generator

[GitBox <gi...@apache.org>]

michaelmior commented on a change in pull request #1319: [CALCITE-3195] Handle UDF that throws checked exceptions in enumerable code generator
URL: https://github.com/apache/calcite/pull/1319#discussion_r306310187
 
 

 ##########
 File path: linq4j/src/test/java/org/apache/calcite/linq4j/test/InlinerTest.java
 ##########
 @@ -194,6 +196,40 @@ void checkAssignInConditionOptimizedOut(int modifiers, String s) {
             + "}\n",
         Expressions.toString(builder.toBlock()));
   }
+
+  @Test public void testInlineInTryCatchStatement() {
+    // final int t = 1;
+    // final int u;
+    // try {
+    //   u = t + 2;
+    // } catch (Exception e) {
+    //   throw e;
+    // }
+    // return u;
 
 Review comment:
   The commented out code above should be removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services