[GitHub] [incubator-dolphinscheduler] dailidong commented on a change in pull request #2396: [optimization]：prevent repeated database updates

[GitBox <gi...@apache.org>]

dailidong commented on a change in pull request #2396: [optimization]：prevent repeated database updates
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2396#discussion_r406793776
 
 

 ##########
 File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java
 ##########
 @@ -308,22 +302,27 @@ private boolean checkTenantSuitable(ProcessDefinition processDefinition) {
     }
 
     /**
-     * update process instance state
+     *  prepare to update process instance command type and status
      *
-     * @param processInstanceId process instance id
+     * @param processInstance process instance
+     * @param commandType command type
      * @param executionStatus execute status
      * @return update result
      */
-    private Map<String, Object> updateProcessInstanceState(Integer processInstanceId, ExecutionStatus executionStatus) {
+    private Map<String, Object> updateProcessInstancePrepare(ProcessInstance processInstance, CommandType commandType, ExecutionStatus executionStatus) {
 
 Review comment:
   method name called updateProcessInstanceState maybe better？ because changed the database state，how do you think ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services