You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jbondc <gi...@git.apache.org> on 2014/03/09 20:05:53 UTC

[GitHub] cordova-windows pull request: "cordova run" test + add common.js l...

GitHub user jbondc opened a pull request:

    https://github.com/apache/cordova-windows/pull/19

    "cordova run" test + add common.js lib

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gdesolutions/cordova-windows CB-6204

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
    
----
commit fff20302634fecc2370a2882fce7f69dee27c66a
Author: jbondc <jb...@openmv.com>
Date:   2014-03-09T19:03:29Z

    "cordova run" test + add common.js lib

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-windows pull request: "cordova run" test + add common.js l...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-windows/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-windows pull request: "cordova run" test + add common.js l...

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-windows/pull/19#issuecomment-41599483
  
    The inclusion of 'eval' to load code is problematic.
    This pull-request will not be merged. You can close it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---