You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by ja...@apache.org on 2014/03/12 01:24:57 UTC
[3/5] git commit: PHOENIX-835 Datatype statements in CAST operations
are case-sensitive (GabrielReid)
PHOENIX-835 Datatype statements in CAST operations are case-sensitive (GabrielReid)
Project: http://git-wip-us.apache.org/repos/asf/incubator-phoenix/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-phoenix/commit/e370cc5f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-phoenix/tree/e370cc5f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-phoenix/diff/e370cc5f
Branch: refs/heads/4.0
Commit: e370cc5ffc7c800e434f1940aa21e459ab3c0ca4
Parents: 293e865
Author: jamestaylor <ja...@apache.org>
Authored: Tue Mar 11 16:05:51 2014 -0700
Committer: jamestaylor <ja...@apache.org>
Committed: Tue Mar 11 17:19:33 2014 -0700
----------------------------------------------------------------------
.../src/main/java/org/apache/phoenix/parse/CastParseNode.java | 3 ++-
.../src/test/java/org/apache/phoenix/end2end/QueryTest.java | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-phoenix/blob/e370cc5f/phoenix-core/src/main/java/org/apache/phoenix/parse/CastParseNode.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/main/java/org/apache/phoenix/parse/CastParseNode.java b/phoenix-core/src/main/java/org/apache/phoenix/parse/CastParseNode.java
index 3cda048..9bc2b41 100644
--- a/phoenix-core/src/main/java/org/apache/phoenix/parse/CastParseNode.java
+++ b/phoenix-core/src/main/java/org/apache/phoenix/parse/CastParseNode.java
@@ -26,6 +26,7 @@ import org.apache.phoenix.expression.function.RoundDecimalExpression;
import org.apache.phoenix.expression.function.RoundTimestampExpression;
import org.apache.phoenix.schema.PDataType;
import org.apache.phoenix.schema.TypeMismatchException;
+import org.apache.phoenix.util.SchemaUtil;
/**
*
@@ -41,7 +42,7 @@ public class CastParseNode extends UnaryParseNode {
CastParseNode(ParseNode expr, String dataType) {
super(expr);
- dt = PDataType.fromSqlTypeName(dataType);
+ dt = PDataType.fromSqlTypeName(SchemaUtil.normalizeIdentifier(dataType));
}
CastParseNode(ParseNode expr, PDataType dataType) {
http://git-wip-us.apache.org/repos/asf/incubator-phoenix/blob/e370cc5f/phoenix-core/src/test/java/org/apache/phoenix/end2end/QueryTest.java
----------------------------------------------------------------------
diff --git a/phoenix-core/src/test/java/org/apache/phoenix/end2end/QueryTest.java b/phoenix-core/src/test/java/org/apache/phoenix/end2end/QueryTest.java
index d5b1b51..69815bb 100644
--- a/phoenix-core/src/test/java/org/apache/phoenix/end2end/QueryTest.java
+++ b/phoenix-core/src/test/java/org/apache/phoenix/end2end/QueryTest.java
@@ -2766,7 +2766,7 @@ public class QueryTest extends BaseClientManagedTimeTest {
@Test
public void testCastOperatorInSelect() throws Exception {
- String query = "SELECT CAST(a_integer AS DECIMAL)/2 FROM aTable WHERE ?=organization_id and 5=a_integer";
+ String query = "SELECT CAST(a_integer AS decimal)/2 FROM aTable WHERE ?=organization_id and 5=a_integer";
Properties props = new Properties(TEST_PROPERTIES);
props.setProperty(PhoenixRuntime.CURRENT_SCN_ATTRIB, Long.toString(ts + 2)); // Execute at timestamp 2
Connection conn = DriverManager.getConnection(PHOENIX_JDBC_URL, props);