You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Mark Reynolds (JIRA)" <ji...@codehaus.org> on 2007/12/12 03:34:57 UTC
[jira] Created: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Regression: pom properties are no longer expanded in descriptor.
----------------------------------------------------------------
Key: MASSEMBLY-256
URL: http://jira.codehaus.org/browse/MASSEMBLY-256
Project: Maven 2.x Assembly Plugin
Issue Type: Bug
Affects Versions: 2.2-beta-2
Environment: maven 2.0.8
windows xp sp2
Reporter: Mark Reynolds
Attachments: assembly-issue.zip
Attached is a minimal project which demonstrates this issue.
The pom contains a property:
<project>
...
<properties>
<fileLocation>file/path</fileLocation>
</properties>
</project>
The descriptor uses this property in specifying the output directory for a fileSet:
<assembly>
...
<fileSets>
<fileSet>
<directory>src/main/files</directory>
<outputDirectory>${fileLocation}</outputDirectory>
</fileSet>
</fileSets>
</assembly>
In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_124976 ]
John Casey commented on MASSEMBLY-256:
--------------------------------------
Are you saying that the code changes I made aren't affecting this issue? The problem is, we have two-stage "interpolation" if you like in the assembly descriptor. Stage one uses only information from the project being built, and happens up front before the assembly is put together. In this stage, the output locations are not subject to interpolation, since they may have properties referring to the artifacts/files they are dealing with. Stage two happens at the point where a dependencySet, fileSet, etc. is actually included in the assembly. In this case, artifact information is combined with information from the current project, to enable both things like ${project.build.finalName} and ${project.properties.foo}, along with ${artifact.artifactId}.
The ${project.properties.foo} is actually the part that changed very recently, allowing their inclusion in these output locations. I've deployed a proposed release for the assembly plugin for people to test, though I can't be certain that I deployed a snapshot of the assembly plugin with this code in place. Please see:
http://article.gmane.org/gmane.comp.jakarta.turbine.maven.devel/84081
for links and instructions on testing.
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-2
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "Mark Reynolds (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_124987 ]
Mark Reynolds commented on MASSEMBLY-256:
-----------------------------------------
I pointed to your staging repo but I am still not having any luck. I don't think this is working. Using my original example, I have tried <outputDirectory>${fileLocation}</outputDirectory> and <outputDirectory>${project.properties.fileLocation}</outputDirectory> in the descriptor. When I package with -X i see something like this:
[DEBUG] Configuring mojo 'org.apache.maven.plugins:maven-assembly-plugin:2.2-beta-2:attached' -->
[DEBUG] (s) appendAssemblyId = true
[DEBUG] (f) attach = true
[DEBUG] (s) basedir = C:\Documents and Settings\mreynolds\Desktop\assembly-issue
[DEBUG] (s) descriptors = [Ljava.lang.String;@154864a
[DEBUG] (f) dryRun = false
[DEBUG] (s) finalName = myartifact-1.0-SNAPSHOT
[DEBUG] (f) ignoreDirFormatExtensions = false
[DEBUG] (s) ignoreMissingDescriptor = false
[DEBUG] (s) includeSite = false
[DEBUG] (s) localRepository = [local] -> file://C:\Documents and Settings\mreynolds\.m2\repository
[DEBUG] (s) outputDirectory = C:\Documents and Settings\mreynolds\Desktop\assembly-issue\target
[DEBUG] (f) project = MavenProject: com.whatever:myartifact:1.0-SNAPSHOT @ C:\Documents and Settings\mreynolds\Desktop\assembly-issue\pom.xml
[DEBUG] (s) reactorProjects = [MavenProject: com.whatever:myartifact:1.0-SNAPSHOT @ C:\Documents and Settings\mreynolds\Desktop\assembly-issue\pom.x
ml]
[DEBUG] (f) remoteRepositories = [[mrb.stage] -> http://people.apache.org/~jdcasey/stage/maven-repository-builder/1.0-alpha-2, [map.stage] -> http:/
/people.apache.org/~jdcasey/stage/maven-assembly-plugin/2.2-beta-2, [central] -> http://repo1.maven.org/maven2]
[DEBUG] (s) siteDirectory = C:\Documents and Settings\mreynolds\Desktop\assembly-issue\target\site
[DEBUG] (f) skipAssembly = false
[DEBUG] (s) tarLongFileMode = warn
[DEBUG] (s) tempRoot = C:\Documents and Settings\mreynolds\Desktop\assembly-issue\target\archive-tmp
[DEBUG] (s) workDirectory = C:\Documents and Settings\mreynolds\Desktop\assembly-issue\target\assembly\work
[DEBUG] -- end configuration --
[INFO] [assembly:attached {execution: default}]
[INFO] Reading assembly descriptor: src/main/assembly/myassembly.xml
[DEBUG] Before assembly is interpolated:
<?xml version="1.0" encoding="UTF-8"?><assembly>
<id>myassembly</id>
<formats>
<format>zip</format>
</formats>
<includeBaseDirectory>false</includeBaseDirectory>
<fileSets>
<fileSet>
<directory>src/main/files</directory>
<outputDirectory>${project.properties.fileLocation}</outputDirectory>
</fileSet>
</fileSets>
</assembly>
[DEBUG] After assembly is interpolated:
<?xml version="1.0" encoding="UTF-8"?><assembly>
<id>myassembly</id>
<formats>
<format>zip</format>
</formats>
<includeBaseDirectory>false</includeBaseDirectory>
<fileSets>
<fileSet>
<directory>src/main/files</directory>
<outputDirectory>${project.properties.fileLocation}</outputDirectory>
</fileSet>
</fileSets>
</assembly>
[DEBUG] All known ContainerDescritporHandler components: [plexus]
[DEBUG] No dependency sets specified.
[DEBUG] FileSet[${project.properties.fileLocation}] dir perms: 40755 file perms: 100644
[DEBUG] The archive base directory is 'null'
[DEBUG] Adding file-set from directory: 'C:\Documents and Settings\mreynolds\Desktop\assembly-issue\src\main\files'
assembly output directory is: '${project.properties.fileLocation}/'
[DEBUG] Adding directory file-set in: C:\Documents and Settings\mreynolds\Desktop\assembly-issue\src\main\files to archive location: ${project.propert
ies.fileLocation}/
[INFO] Building zip: C:\Documents and Settings\mreynolds\Desktop\assembly-issue\target\myartifact-1.0-SNAPSHOT-myassembly.zip
[DEBUG] adding directory ${project.properties.fileLocation}/
[DEBUG] adding entry ${project.properties.fileLocation}/some.file
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3 seconds
[INFO] Finished at: Mon Feb 25 11:12:44 EST 2008
[INFO] Final Memory: 7M/15M
[INFO] ------------------------------------------------------------------------
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-2
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MASSEMBLY-256) Regression: pom properties are no longer
expanded in descriptor.
Posted by "Hannes Kogler (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=316082#comment-316082 ]
Hannes Kogler edited comment on MASSEMBLY-256 at 12/21/12 5:49 AM:
-------------------------------------------------------------------
anybody here, to give a good reason why the interpolation is deactivated in the descriptor's sections by this code?
blacklist.add( "outputFileNameMapping" );
blacklist.add( "outputDirectoryMapping" );
blacklist.add( "outputDirectory" );
I think ESPECIALLY at those 3 tags the interpolation would make the most sense..
or is there any opional parameter do deactivate this blacklist-behavior?
was (Author: ntshko):
anybody here, to give a good reason why the interpolation is deactivated in the descriptor's sections by this code?
blacklist.add( "outputFileNameMapping" );
blacklist.add( "outputDirectoryMapping" );
blacklist.add( "outputDirectory" );
I think ESPECIALLY at those 3 tags the interpolation would make the most sense..
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: https://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1, 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "Mark Reynolds (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_125008 ]
Mark Reynolds commented on MASSEMBLY-256:
-----------------------------------------
Same result.
I have tried the following, with none of them working:
${fileLocation}
${properties.fileLocation}
${pom.properties.fileLocation}
${project.properties.fileLocation}
With prior versions (2.1, 2.2-beta-1, and 2.2-SNAPSHOT), ${fileLocation} worked.
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1, 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MASSEMBLY-256:
---------------------------------
Affects Version/s: (was: 2.2-beta-3)
2.2-beta-2
Fix Version/s: 2.2-beta-2
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Fix For: 2.2-beta-2
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey closed MASSEMBLY-256.
--------------------------------
Resolution: Fixed
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-2
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_125024 ]
John Casey commented on MASSEMBLY-256:
--------------------------------------
Ah, sorry. Too many reloads of this page, combined with bad scrolling skills on my part.
I'll take another look into why the expression resolver changes I made are not percolating to the level at which you can use them, and if I can get it fixed with reasonable effort, I'll suspend the current vote and re-start it with a new RC.
Thanks, and sorry for the confusion.
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1, 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_121967 ]
Paul Gier commented on MASSEMBLY-256:
-------------------------------------
The offending code is located in the AssemblyInterpolator.
{code:java}
static
{
Set blacklist = new HashSet();
blacklist.add( "outputFileNameMapping" );
blacklist.add( "outputDirectoryMapping" );
blacklist.add( "outputDirectory" );
INTERPOLATION_BLACKLIST = blacklist;
}
{code}
Apparently outputDirectory is not allowed to have a property in it, although I'm not sure about the reasoning.
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_123721 ]
John Casey commented on MASSEMBLY-256:
--------------------------------------
It's actually just suppressed from interpolation at this stage, so it can be handled separately later. This allows the use of ${artifactId} to refer to the specific artifact being processed in a given dependencySet, things like that.
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Fix For: 2.2-beta-2
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "Viktor Nordling (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126027 ]
Viktor Nordling commented on MASSEMBLY-256:
-------------------------------------------
Thanks for fixing this.
I just want to point out that this caused an issue for us and it took a few hours off of my working day to figure out that it was not my fault, but that I suddenly got a new version of the assembly plugin that was broken.
It's a bit scary when this happens, from now on we will be setting the plugin version explicitly in our pom. This should probably be a "recommended practice" from the Maven team, or is it already?
No need to dwell on it, my point is just that there are people out there who will get some nasty surprises.
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1, 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey closed MASSEMBLY-256.
--------------------------------
Resolution: Fixed
I haven't deployed a snapshot of this yet, to avoid muddying the waters since 2.2-beta-2 isn't released yet, but it's changed in revId: 630965.
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1, 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_125117 ]
John Casey commented on MASSEMBLY-256:
--------------------------------------
Okay, I've added the attached test zip as an integration test to the assembly plugin, and what I found in doing so was that 2.2-beta-2 (the current one proposed) does work with ${fileLocation} but not with ${pom.fileLocation}, ${pom.properties.fileLocation}, ${project.fileLocation}, or ${project.properties.fileLocation}.
Can you check again to see whether ${fileLocation} is working for you using the 2.2-beta-2 version I have staged? If it doesn't, maybe you can help me understand why the integration test I added in revId: 631043 doesn't reflect your test.
If you want to see those changes online, have a look at:
http://svn.apache.org/viewvc?view=rev&revision=631043
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1, 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "Mark Reynolds (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_125021 ]
Mark Reynolds commented on MASSEMBLY-256:
-----------------------------------------
Thanks John. I am not concerned with the syntax, and I don't mind modifying my assembly descriptors. But I would hate to change parameterized paths to hard-coded paths.
Perhaps I misunderstood you. As I said in my comment above, I have tested
<outputDirectory>${pom.properties.fileLocation}</outputDirectory>
with the staged release candidate and it doesn't work. In your subsequent post, I understood you to be saying that you have now fixed that for the first 2.2-beta-3-SNAPSHOT (but haven't deployed it yet), and that the inability to parameterize the <outputDirectory> will not be fixed for the the 2.2-beta-2 release.
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1, 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "Mark Reynolds (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_125010 ]
Mark Reynolds commented on MASSEMBLY-256:
-----------------------------------------
I was really looking forward to getting onto a released version. At this rate it will be 2009. :(
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1, 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_125011 ]
John Casey commented on MASSEMBLY-256:
--------------------------------------
I don't know how many of these assembly descriptors you maintain, but using the ${pom.properties.*} and ${pom.*} expressions should be a viable, forward-compatible solution for you.
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1, 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MASSEMBLY-256) Regression: pom properties are no longer
expanded in descriptor.
Posted by "Hannes Kogler (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=316082#comment-316082 ]
Hannes Kogler commented on MASSEMBLY-256:
-----------------------------------------
anybody here, to give a good reason why the interpolation is deactivated in the descriptor's sections by this code?
blacklist.add( "outputFileNameMapping" );
blacklist.add( "outputDirectoryMapping" );
blacklist.add( "outputDirectory" );
I think ESPECIALLY at those 3 tags the interpolation would make the most sense..
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: https://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1, 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "Mark Reynolds (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_125118 ]
Mark Reynolds commented on MASSEMBLY-256:
-----------------------------------------
That does work for me! If nothing has changed in the staged build, then this is my bad. I was trying different combinations of versions of the plugin and ways of referencing the property and must have messed up. This is why I would not be any good in QA! Thanks for taking the time to look into this.
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1, 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "Mark Reynolds (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Reynolds reopened MASSEMBLY-256:
-------------------------------------
Just reopening for a clarification. This is marked as fixed, but I don't see any change in behavior. Does this mean that using a property in the <outputDirectory> is not supported for the next release?
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-2
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MASSEMBLY-256) Regression: pom properties are no
longer expanded in descriptor.
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MASSEMBLY-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Casey updated MASSEMBLY-256:
---------------------------------
Affects Version/s: 2.2-beta-1
Fix Version/s: (was: 2.2-beta-2)
2.2-beta-3
The problem is your use of the prefix 'project.' to refer to these properties. I understand that the prefixes 'pom.' and 'project.' are commonly interchangeable in Maven, and I'm adding code right now to add support for 'project.'
However, for the 2.2-beta-2 release, I don't think it's critical to add support for project. expressions and re-start the entire voting process. I'd prefer to push for a next release in short order, and get this one out with valid 'pom.' expression support.
Can you verify that the example you're testing against will work if you use ${pom.properties.fileLocation}?
> Regression: pom properties are no longer expanded in descriptor.
> ----------------------------------------------------------------
>
> Key: MASSEMBLY-256
> URL: http://jira.codehaus.org/browse/MASSEMBLY-256
> Project: Maven 2.x Assembly Plugin
> Issue Type: Bug
> Affects Versions: 2.2-beta-1, 2.2-beta-2
> Environment: maven 2.0.8
> windows xp sp2
> Reporter: Mark Reynolds
> Assignee: John Casey
> Fix For: 2.2-beta-3
>
> Attachments: assembly-issue.zip
>
>
> Attached is a minimal project which demonstrates this issue.
> The pom contains a property:
> <project>
> ...
> <properties>
> <fileLocation>file/path</fileLocation>
> </properties>
> </project>
> The descriptor uses this property in specifying the output directory for a fileSet:
> <assembly>
> ...
> <fileSets>
> <fileSet>
> <directory>src/main/files</directory>
> <outputDirectory>${fileLocation}</outputDirectory>
> </fileSet>
> </fileSets>
> </assembly>
> In versions 2.1, 2.2-beta-1, and 2.2-SNAPSHOT of the assembly plugin, this property is expanded so the resulting archive has files in file/path/....
> In the latest 2.2-beta-2-SNAPSHOT, the resulting archive has files in ${fileLocation}/...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira