[GitHub] [incubator-nuttx] patacongo commented on issue #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS

[GitBox <gi...@apache.org>]

patacongo commented on issue #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS
URL: https://github.com/apache/incubator-nuttx/pull/684#issuecomment-614838793
 
 
   Was this file created just for NuttX?  Does it have a history as a PX4 file that is being brought into NuttX?  In this latter case, there this a license issue.  I don't think that the author has the authority to change the license.
   
   On the other hand, If the file was created specifically for NuttX and has never been a part of PX4, then I would say that the creator of the file simply put the wrong license on the file due to a lack of understanding of the license requirements.  In this latter case, it is just a legitimate error and not really a license issue since it was never a part of PX4.  However, if this is the case, then you probably should amend the commit so that it does not appear that it was a PX4 file that has  had its license inappropriately changed.
   
   If merged as is, then this will forever be a licensing problem.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services