Re: [PR] [KYUUBI #6368] Flink engine supports user impersonation [kyuubi]

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #6383:
URL: https://github.com/apache/kyuubi/pull/6383#discussion_r1635768060


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/credentials/HadoopFsDelegationTokenProvider.scala:
##########
@@ -68,12 +68,10 @@ class HadoopFsDelegationTokenProvider extends HadoopDelegationTokenProvider with
       }.toMap
 
       try {
-        // Renewer is not needed. But setting a renewer can avoid potential NPE.
-        val renewer = UserGroupInformation.getCurrentUser.getUserName

Review Comment:
   this change is worth a dedicated PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org