You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/01 16:35:39 UTC

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1158: HDDS-3909. Use ContainerScrubberConfiguration in ChunkManagerFactory

adoroszlai opened a new pull request #1158:
URL: https://github.com/apache/hadoop-ozone/pull/1158


   ## What changes were proposed in this pull request?
   
   Use existing type-safe ContainerScrubberConfiguration in ChunkManagerFactory instead of constants-based lookup.
   
   https://issues.apache.org/jira/browse/HDDS-3909
   
   ## How was this patch tested?
   
   Tested warning logged with various settings:
   
   ```
   OZONE-SITE.XML_hdds.container.scrub.enabled=true
   OZONE-SITE.XML_hdds.container.chunk.persistdata=false
   
   ->
   
   WARN impl.ChunkManagerFactory: Failed to set hdds.container.chunk.persistdata to false. Please set hdds.container.scrub.enabled also to false to enable non-persistent containers.
   ```
   
   ```
   OZONE-SITE.XML_hdds.container.scrub.enabled=false
   OZONE-SITE.XML_hdds.container.chunk.persistdata=false
   
   ->
   
   WARN impl.ChunkManagerFactory: hdds.container.chunk.persistdata is set to false. This should be used only for testing. All user data will be discarded.
   ```
   
   ```
   OZONE-SITE.XML_hdds.container.scrub.enabled=true
   OZONE-SITE.XML_hdds.container.chunk.persistdata=true
   
   ->
   
   <no warning>
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1158: HDDS-3909. Use ContainerScrubberConfiguration in ChunkManagerFactory

Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1158:
URL: https://github.com/apache/hadoop-ozone/pull/1158


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1158: HDDS-3909. Use ContainerScrubberConfiguration in ChunkManagerFactory

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1158:
URL: https://github.com/apache/hadoop-ozone/pull/1158#issuecomment-655350939


   Thanks @xiaoyuyao for the review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org