You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ck...@apache.org on 2020/09/14 15:16:06 UTC
[httpcomponents-core] 07/13: HTTPCORE-645: Increase blocking
default chunk size from 2 KiB to 8 KiB
This is an automated email from the ASF dual-hosted git repository.
ckozak pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git
commit adcd4cf0785638c63efedcf02b15979206336b7e
Author: Carter Kozak <ck...@apache.org>
AuthorDate: Mon Sep 14 11:14:33 2020 -0400
HTTPCORE-645: Increase blocking default chunk size from 2 KiB to 8 KiB
This value matches the default session buffer size and avoids
excessive memory copying between the chunk buffer and session
buffer.
---
.../main/java/org/apache/hc/core5/http/impl/io/BHttpConnectionBase.java | 2 +-
.../main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/BHttpConnectionBase.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/BHttpConnectionBase.java
index 95168ad..ecbb010 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/BHttpConnectionBase.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/BHttpConnectionBase.java
@@ -158,7 +158,7 @@ class BHttpConnectionBase implements BHttpConnection {
private byte[] getChunkedRequestBuffer() {
if (chunkedRequestBuffer == null) {
final int chunkSizeHint = this.http1Config.getChunkSizeHint();
- chunkedRequestBuffer = new byte[chunkSizeHint > 0 ? chunkSizeHint : 2048];
+ chunkedRequestBuffer = new byte[chunkSizeHint > 0 ? chunkSizeHint : 8192];
}
return chunkedRequestBuffer;
}
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java
index b8ab5fd..23eb5e3 100644
--- a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java
+++ b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/ChunkedOutputStream.java
@@ -102,7 +102,7 @@ public class ChunkedOutputStream extends OutputStream {
final OutputStream outputStream,
final int chunkSizeHint,
final Supplier<List<? extends Header>> trailerSupplier) {
- this(buffer, outputStream, new byte[chunkSizeHint > 0 ? chunkSizeHint : 2048], trailerSupplier);
+ this(buffer, outputStream, new byte[chunkSizeHint > 0 ? chunkSizeHint : 8192], trailerSupplier);
}
/**