You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/10/29 02:50:53 UTC
[GitHub] [ozone] JunLuo opened a new pull request #2783: HDDS-5912. update description of hdds.datanode.dir
JunLuo opened a new pull request #2783:
URL: https://github.com/apache/ozone/pull/2783
## What changes were proposed in this pull request?
add description of datanode data dir in Ozone On Premise Installation of Gettting Started
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2783: HDDS-5912. Add description of hdds.datanode.dir in Getting Started
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2783:
URL: https://github.com/apache/ozone/pull/2783#discussion_r744890072
##########
File path: hadoop-hdds/docs/content/start/OnPrem.md
##########
@@ -115,6 +126,7 @@ Here is an example,
| ozone.scm.client.address | SCM server name and port | Used by client-side |
| ozone.scm.datanode.address | SCM server name and port | Used by datanode to talk to SCM |
| ozone.om.address | OM server name | Used by Ozone handler and Ozone file system. |
+| hdds.datanode.dir | file path | The HDDS data will be stored here. |
Review comment:
```suggestion
| hdds.datanode.dir | file path | HDDS datanodes store data in this directory. |
```
##########
File path: hadoop-hdds/docs/content/start/OnPrem.zh.md
##########
@@ -87,6 +87,18 @@ ozone genconf <path>
</property>
{{< /highlight >}}
+* **hdds.datanode.dir** HDDS数据在datanode本地文件系统中的存储路径，如果路径不存在，ozone会自动创建。
+如果没有指定该选项，ozone会默认使用dfs.datanode.data.dir的值，
+
+示例如下：
+
+{{< highlight xml >}}
+ <property>
+ <name>hdds.datanode.dir</name>
+ <value>/data/disk1/data</value>
+ </property>
+{{< /highlight >}}
+
Review comment:
```suggestion
```
##########
File path: hadoop-hdds/docs/content/start/OnPrem.md
##########
@@ -104,6 +104,17 @@ Here is an example,
</property>
{{< /highlight >}}
+* **hdds.datanode.dir** Determines where on the local filesystem HDDS data will be
+stored. Defaults to dfs.datanode.data.dir if not specified.
+
+Here is an example,
+{{< highlight xml >}}
+ <property>
+ <name>hdds.datanode.dir</name>
+ <value>/data/disk1/data</value>
+ </property>
+{{< /highlight >}}
+
Review comment:
This section lists properties which are present in the `ozone-site.xml` config file created by `ozone genconf`. `hdds.datanode.dir` is not such a property, so I think this section should not list it.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JunLuo commented on pull request #2783: HDDS-5912. Add description of hdds.datanode.dir in Getting Started
Posted by GitBox <gi...@apache.org>.
JunLuo commented on pull request #2783:
URL: https://github.com/apache/ozone/pull/2783#issuecomment-963855144
Because the property "hdds.datanode.dir" doesn't contain "REQUIRED" tag, it is not generated in genconf. But the default value of "hdds.datanode.dir" can be misleading for user, especially new users. So, Is it necessary to add required tag for hdds.datanode.dir?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2783: HDDS-5912. Add description of hdds.datanode.dir in Getting Started
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2783:
URL: https://github.com/apache/ozone/pull/2783#issuecomment-994512698
Thanks @JunLuo for the patch, and sorry for the in merging it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #2783: HDDS-5912. Add description of hdds.datanode.dir in Getting Started
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2783:
URL: https://github.com/apache/ozone/pull/2783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org