You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "sheikhoo (via GitHub)" <gi...@apache.org> on 2023/06/13 16:18:48 UTC
[GitHub] [tomcat] sheikhoo opened a new pull request, #628: Change style
sheikhoo opened a new pull request, #628:
URL: https://github.com/apache/tomcat/pull/628
Just change some CSS style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] sheikhoo commented on pull request #628: Change style
Posted by "sheikhoo (via GitHub)" <gi...@apache.org>.
sheikhoo commented on PR #628:
URL: https://github.com/apache/tomcat/pull/628#issuecomment-1590358538
I removed any unnecessary spaces and utilized 4 spaces instead of 1 tab. Additionally, I updated the style of the buttons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on a diff in pull request #628: Change style
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on code in PR #628:
URL: https://github.com/apache/tomcat/pull/628#discussion_r1238933690
##########
webapps/host-manager/css/manager.css:
##########
@@ -125,6 +132,16 @@ TD {
vertical-align: middle;
font-family : sans-serif, Tahoma, Arial;
color : black;
+ padding : 5px;
+ color : #636363;
Review Comment:
Switching from Black to Grey reduces the contrast and makes it harder to read. I think it would be better left as black. It is also odd to have the titles stand out less than the content.
##########
webapps/host-manager/css/manager.css:
##########
@@ -138,4 +155,59 @@ form.inline {
img.tomcat-logo {
height: 92px;
float : left;
-}
\ No newline at end of file
+}
+
+input[type="submit" i] {
+ appearance: none;
+ background-color: #FAFBFC;
+ border: 1px solid rgba(27, 31, 35, 0.15);
+ border-radius: 6px;
+ box-shadow: rgba(27, 31, 35, 0.04) 0 1px 0, rgba(255, 255, 255, 0.25) 0 1px 0 inset;
+ box-sizing: border-box;
+ color: #24292E;
+ cursor: pointer;
+ display: inline-block;
+ font-size: 14px;
+ font-weight: 500;
+ line-height: 20px;
+ list-style: none;
+ padding: 6px 16px;
+ position: relative;
+ transition: background-color 0.2s cubic-bezier(0.3, 0, 0.5, 1);
+ user-select: none;
+ -webkit-user-select: none;
+ touch-action: manipulation;
+ vertical-align: middle;
+ white-space: nowrap;
+ word-wrap: break-word;
+}
+
+input[type="submit" i]:hover {
+ background-color: #F3F4F6;
+ text-decoration: none;
+ transition-duration: 0.1s;
+}
+
+input[type="submit" i]:active {
+ background-color: #EDEFF2;
+ box-shadow: rgba(225, 228, 232, 0.2) 0 1px 0 inset;
+ transition: none 0s;
+}
+
Review Comment:
You have trailing spaces on this line that need to be removed. If you run the build with Checkstyle enabled it will find any issues like this.
##########
webapps/manager/css/manager.css:
##########
@@ -125,6 +132,16 @@ TD {
vertical-align: middle;
font-family : sans-serif, Tahoma, Arial;
color : black;
+ padding : 5px;
+ color : #636363;
Review Comment:
Same as above.
##########
webapps/manager/css/manager.css:
##########
@@ -138,4 +155,59 @@ form.inline {
img.tomcat-logo {
height: 92px;
float : left;
-}
\ No newline at end of file
+}
+
+input[type="submit" i] {
+ appearance: none;
+ background-color: #FAFBFC;
+ border: 1px solid rgba(27, 31, 35, 0.15);
+ border-radius: 6px;
+ box-shadow: rgba(27, 31, 35, 0.04) 0 1px 0, rgba(255, 255, 255, 0.25) 0 1px 0 inset;
+ box-sizing: border-box;
+ color: #24292E;
+ cursor: pointer;
+ display: inline-block;
+ font-size: 14px;
+ font-weight: 500;
+ line-height: 20px;
+ list-style: none;
+ padding: 6px 16px;
+ position: relative;
+ transition: background-color 0.2s cubic-bezier(0.3, 0, 0.5, 1);
+ user-select: none;
+ -webkit-user-select: none;
+ touch-action: manipulation;
+ vertical-align: middle;
+ white-space: nowrap;
+ word-wrap: break-word;
+}
+
+input[type="submit" i]:hover {
+ background-color: #F3F4F6;
+ text-decoration: none;
+ transition-duration: 0.1s;
+}
+
+input[type="submit" i]:active {
+ background-color: #EDEFF2;
+ box-shadow: rgba(225, 228, 232, 0.2) 0 1px 0 inset;
+ transition: none 0s;
+}
+
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #628: Change style
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #628:
URL: https://github.com/apache/tomcat/pull/628#issuecomment-1592582873
Thanks for addressing the feedback. The remaining question is "What is the reason for these changes?"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] sheikhoo commented on pull request #628: Change style
Posted by "sheikhoo (via GitHub)" <gi...@apache.org>.
sheikhoo commented on PR #628:
URL: https://github.com/apache/tomcat/pull/628#issuecomment-1592794504
> Thanks for addressing the feedback. The remaining question is "What is the reason for these changes?"
The reason behind these modifications is to enhance the visual appeal of the software and provide a more modern look. By removing unnecessary elements such as table borders.
I would like to redesign the frontend architecture of the project in a modern way if you agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on a diff in pull request #628: Change style
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on code in PR #628:
URL: https://github.com/apache/tomcat/pull/628#discussion_r1228412571
##########
webapps/host-manager/css/manager.css:
##########
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-body {
+ body {
font-family: Tahoma, Arial, sans-serif;
Review Comment:
This change appears to be unnecessary
##########
webapps/host-manager/css/manager.css:
##########
@@ -73,6 +79,7 @@ td.title {
font-style : italic;
font-weight : bold;
background : #D2A41C;
+ border-radius : 10px 10px 0 0;
Review Comment:
Use 4 spaces rather than 1 tab for indents. This comment applies globally, not just to this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #628: Change style
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #628:
URL: https://github.com/apache/tomcat/pull/628#issuecomment-1597337218
Please provide an updated screenshot showing the results of all your changes as there have been additional changes since the PR was opened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] sheikhoo commented on pull request #628: Change style
Posted by "sheikhoo (via GitHub)" <gi...@apache.org>.
sheikhoo commented on PR #628:
URL: https://github.com/apache/tomcat/pull/628#issuecomment-1601089024
> Please provide an updated screenshot showing the results of all your changes as there have been additional changes since the PR was opened.
This is screenshot of last change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org