[GitHub] [helix] qqu0127 commented on a diff in pull request #2353: Implement direct child change listener in ZkMetaClient

["qqu0127 (via GitHub)" <gi...@apache.org>]

qqu0127 commented on code in PR #2353:
URL: https://github.com/apache/helix/pull/2353#discussion_r1090798500


##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -258,7 +260,12 @@ public boolean subscribeDataChange(String key, DataChangeListener listener,
   public DirectChildSubscribeResult subscribeDirectChildChange(String key,
       DirectChildChangeListener listener, boolean skipWatchingNonExistNode,
       boolean persistListener) {

Review Comment:
   To make sure I understand, this method is from a public interface from metaclient. Are you proposing to have different APIs for persistent vs non-persistent listener?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org