You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/11/22 04:59:41 UTC
[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3090: Add missing deprecation annotations in Mutation
ctubbsii commented on code in PR #3090:
URL: https://github.com/apache/accumulo/pull/3090#discussion_r1028829671
##########
core/src/main/java/org/apache/accumulo/core/data/Mutation.java:
##########
@@ -1507,6 +1507,7 @@ public int size() {
* the peer to add
* @since 1.7.0
*/
+ @Deprecated(since = "2.1.1")
Review Comment:
Maybe. That seems a bit misleading to me. The two perspectives are:
1. that it was deprecated in 2.1.0 but failed to be marked as such, or
2. the act of marking it deprecated is what makes it so, because deprecation is about communication, so if we didn't communicate it, it wasn't deprecated.
But then, for the second perspective, if we document on the release notes for 2.1.0 that is deprecated and should have been marked as such, then we will have communicated it.
So, I'm torn, and can see it both ways. I'd like more opinions to help swing one way or the other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org