[GitHub] [spark] tgravescs commented on a change in pull request #28429: [SPARK-31621] [CORE] Fixing Spark Master UI Issue when application is waiting for workers to launch driver

[GitBox <gi...@apache.org>]

tgravescs commented on a change in pull request #28429:
URL: https://github.com/apache/spark/pull/28429#discussion_r419495926



##########
File path: core/src/main/scala/org/apache/spark/deploy/StandaloneResourceUtils.scala
##########
@@ -142,9 +142,13 @@ private[spark] object StandaloneResourceUtils extends Logging {
 
   // used for UI
   def formatResourcesAddresses(resources: Map[String, ResourceInformation]): String = {
-    resources.map { case (rName, rInfo) =>
-      s"$rName: ${rInfo.addresses.mkString("[", ", ", "]")}"
-    }.mkString(", ")
+    if (resources != null) {

Review comment:
       We should fix this so that resources can't be null. it should be an empty map which would return empty string.
   
   Can you please fix DriverInfo:
     private var _resources: Map[String, ResourceInformation] = _
   
   That should be initialized to Map.empty.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org