You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by danielsoro <gi...@git.apache.org> on 2018/12/17 17:23:22 UTC

[GitHub] tomee pull request #287: Fix test for TomEECliIT

GitHub user danielsoro opened a pull request:

    https://github.com/apache/tomee/pull/287

    Fix test for TomEECliIT

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/danielsoro/tomee tomeE-7.1.x-fix-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/287.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #287
    
----
commit da3f40df938e1bf14cee41fba41e67ed480bc8dc
Author: Daniel Cunha (soro) <da...@...>
Date:   2018-12-17T17:19:49Z

    Fix test for TomEECliIT

----


---

[GitHub] tomee issue #287: Fix test for TomEECliIT

Posted by radcortez <gi...@git.apache.org>.
Github user radcortez commented on the issue:

    https://github.com/apache/tomee/pull/287
  
    hey @danielsoro I've tried to apply the patch and run the test, but I have the following assertion fails:
    
    ```
    [ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 3.062 s <<< FAILURE! - in org.apache.tomee.TomEECliIT
    [ERROR] testTomEECliWithJar(org.apache.tomee.TomEECliIT)  Time elapsed: 0.348 s  <<< FAILURE!
    java.lang.AssertionError
    	at org.apache.tomee.TomEECliIT.testTomEECliWithJar(TomEECliIT.java:102)
    
    [ERROR] testTomEECliWithJarCallingAnotherMain(org.apache.tomee.TomEECliIT)  Time elapsed: 0.399 s  <<< FAILURE!
    java.lang.AssertionError
    	at org.apache.tomee.TomEECliIT.testTomEECliWithJarCallingAnotherMain(TomEECliIT.java:219)
    ```
    
    Can you confirm?


---

[GitHub] tomee issue #287: Fix test for TomEECliIT

Posted by danielsoro <gi...@git.apache.org>.
Github user danielsoro commented on the issue:

    https://github.com/apache/tomee/pull/287
  
    @radcortez 
    That is really weird, I can't reproduce the error here. 
    Can you run it in the buildbot to see the results? 


---