[PATCH] for asvn

[Scott Miller <Sc...@prioritytech.com>]

Hello,

I've recently begun using/attempting to use asvn to record file 
permissions and I found it necessary to modify asvn, and I would like to

get the modifications reviewed with the intention of having the changes 
make it back into the asvn available on the Subversion website.  I 
initially attempted to contact Ross Mark (the author of asvn) but his 
controllingedge.com.au address is apparently no longer working.

I understand that this is a subversion development list, but I'm 
offering this patch and I am interested in discussions about the patch 
for a contributed item available on the subversion site and within the 
repository, so this seems to be the best place for such things.  If Ross

or someone else who is actually interested in these fixes and is able to

apply/approve patches, and they want to take this discussion off this 
list, I'd certainly be willing to do that.

Overview of changes made:
   o Commented out the code dealing with symbolic links since subversion
     now has that capability built in.

   o Eliminated the need to traverse the directory tree more than once.
     It now does a single pass, checking each file for device type and
     file permissions.

   o Modified some of the 'find' calls as needed to eliminate processing

     entire subdirectory trees that are not under subversion control.

   o Changed indentation to follow a consistent style.

Respectfully submitted,

-Scott L. Miller
  Senior Network Engineer
  Priority Technologies, Inc.

Re: [PATCH] for asvn

[Peter Samuelson <pe...@p12n.org>]

[Scott Miller]
>    o Changed indentation to follow a consistent style.

A couple things.  (I'm not involved with asvn in any way, mind you.)
First, your patch got attached as a binary file (MIME type
application/octet-stream) so most mail readers, including mine, didn't
just show it as text - I had to jump through a small hoop to read it.
Try to convince your mail reader to give it a "text/something" type
next time, then it's more convenient to review.

Second, regarding your indentation changes:

@@ -62,9 +82,9 @@
     ref=`expr "$dir" : "$refname/\(.*\)"`
     if [ -z "$ref" ]
     then
-        echo .
-    else
-        echo $ref
+                echo .
+                else
+                echo $ref
     fi

That looks quite misguided to me.  First, you messed up the 'else'
line, which was correctly indented at 4 spaces.

Second, this script is for use on Unix, right?  The default tab width
on Unix is 8 spaces, so the existing indentation was 4 spaces per
level.  You changed it to 2 tabs, which is 16 spaces.  (I've converted
tabs to spaces in this mail so you can see what it looks like.)

Your changes seem to indicate that you have a Unix system where tabs
are 4 spaces wide.  I'm curious about what system that is.

Honestly, though, if one is going to use a basic indentation level of
anything other than 8, using tabs in the indents is IMO not a great
idea anyway - just use the appropriate number of spaces.


Finally:

@@ -382,7 +418,8 @@
 
 [ "$ACTION" =  "pre" ] && pre_checkin $@
 
-$SVN $@
+umask 002
+/usr/local/subversion/bin/svn "$@"
 
 [ $? = 0 -a "$ACTION" = "post" ] && post_checkout $@

What is this /usr/local/subversion/bin/svn?  Why did you not want to
use $SVN like everywhere else?