[GitHub] [iceberg] DaVincii commented on a diff in pull request #7872: Dell,Arrow : Migrating test cases in dell,arrow packages to junit5

["DaVincii (via GitHub)" <gi...@apache.org>]

DaVincii commented on code in PR #7872:
URL: https://github.com/apache/iceberg/pull/7872#discussion_r1237362848


##########
dell/src/test/java/org/apache/iceberg/dell/ecs/TestPropertiesSerDesUtil.java:
##########
@@ -20,8 +20,8 @@
 
 import java.util.Map;
 import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Assertions;

Review Comment:
   This class uses @classRule and can't be migrated without some significant refactoring which I feel need some more experience to do. Should I split this pull request into arrow and dell packages as arrow doesn't have any classRules?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org