You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "John Sichi (JIRA)" <ji...@apache.org> on 2010/04/09 02:14:36 UTC

[jira] Created: (HIVE-1297) error message in Hive.checkPaths dumps Java array address instead of path string

error message in Hive.checkPaths dumps Java array address instead of path string
--------------------------------------------------------------------------------

                 Key: HIVE-1297
                 URL: https://issues.apache.org/jira/browse/HIVE-1297
             Project: Hadoop Hive
          Issue Type: Improvement
          Components: Query Processor
    Affects Versions: 0.5.0
            Reporter: John Sichi
            Assignee: John Sichi
             Fix For: 0.6.0


           if (item.isDir()) {
-            throw new HiveException("checkPaths: " + src.toString()
-                + " has nested directory" + item.toString());
+            throw new HiveException("checkPaths: " + src.getPath()
+                + " has nested directory " + item.getPath());
           }


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1297) error message in Hive.checkPaths dumps Java array address instead of path string

Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ning Zhang updated HIVE-1297:
-----------------------------

        Status: Resolved  (was: Patch Available)
    Resolution: Fixed

This has already been fixed in another patch. 

> error message in Hive.checkPaths dumps Java array address instead of path string
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-1297
>                 URL: https://issues.apache.org/jira/browse/HIVE-1297
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1297.1.patch
>
>
> {code}
>            if (item.isDir()) {
> -            throw new HiveException("checkPaths: " + src.toString()
> -                + " has nested directory" + item.toString());
> +            throw new HiveException("checkPaths: " + src.getPath()
> +                + " has nested directory " + item.getPath());
>            }
> {code}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HIVE-1297) error message in Hive.checkPaths dumps Java array address instead of path string

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-1297:
-----------------------------

    Description: 
{code}
           if (item.isDir()) {
-            throw new HiveException("checkPaths: " + src.toString()
-                + " has nested directory" + item.toString());
+            throw new HiveException("checkPaths: " + src.getPath()
+                + " has nested directory " + item.getPath());
           }
{code}


  was:
           if (item.isDir()) {
-            throw new HiveException("checkPaths: " + src.toString()
-                + " has nested directory" + item.toString());
+            throw new HiveException("checkPaths: " + src.getPath()
+                + " has nested directory " + item.getPath());
           }



> error message in Hive.checkPaths dumps Java array address instead of path string
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-1297
>                 URL: https://issues.apache.org/jira/browse/HIVE-1297
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>
> {code}
>            if (item.isDir()) {
> -            throw new HiveException("checkPaths: " + src.toString()
> -                + " has nested directory" + item.toString());
> +            throw new HiveException("checkPaths: " + src.getPath()
> +                + " has nested directory " + item.getPath());
>            }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-1297) error message in Hive.checkPaths dumps Java array address instead of path string

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-1297:
-----------------------------

    Attachment: HIVE-1297.1.patch

> error message in Hive.checkPaths dumps Java array address instead of path string
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-1297
>                 URL: https://issues.apache.org/jira/browse/HIVE-1297
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1297.1.patch
>
>
> {code}
>            if (item.isDir()) {
> -            throw new HiveException("checkPaths: " + src.toString()
> -                + " has nested directory" + item.toString());
> +            throw new HiveException("checkPaths: " + src.getPath()
> +                + " has nested directory " + item.getPath());
>            }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-1297) error message in Hive.checkPaths dumps Java array address instead of path string

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856209#action_12856209 ] 

John Sichi commented on HIVE-1297:
----------------------------------

Were the failures actually related to my change?

I ran through and everything passed...and the "nested directory" string doesn't even appear in ql/src/test/results/clientnegative/*.out.


> error message in Hive.checkPaths dumps Java array address instead of path string
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-1297
>                 URL: https://issues.apache.org/jira/browse/HIVE-1297
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1297.1.patch
>
>
> {code}
>            if (item.isDir()) {
> -            throw new HiveException("checkPaths: " + src.toString()
> -                + " has nested directory" + item.toString());
> +            throw new HiveException("checkPaths: " + src.getPath()
> +                + " has nested directory " + item.getPath());
>            }
> {code}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HIVE-1297) error message in Hive.checkPaths dumps Java array address instead of path string

Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856207#action_12856207 ] 

Ning Zhang commented on HIVE-1297:
----------------------------------

John, TestNegativeCliDriver failed with 35 diffs. Can you take a look?

> error message in Hive.checkPaths dumps Java array address instead of path string
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-1297
>                 URL: https://issues.apache.org/jira/browse/HIVE-1297
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1297.1.patch
>
>
> {code}
>            if (item.isDir()) {
> -            throw new HiveException("checkPaths: " + src.toString()
> -                + " has nested directory" + item.toString());
> +            throw new HiveException("checkPaths: " + src.getPath()
> +                + " has nested directory " + item.getPath());
>            }
> {code}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HIVE-1297) error message in Hive.checkPaths dumps Java array address instead of path string

Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856146#action_12856146 ] 

Ning Zhang commented on HIVE-1297:
----------------------------------

looks good. Will commit if tests pass.

> error message in Hive.checkPaths dumps Java array address instead of path string
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-1297
>                 URL: https://issues.apache.org/jira/browse/HIVE-1297
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1297.1.patch
>
>
> {code}
>            if (item.isDir()) {
> -            throw new HiveException("checkPaths: " + src.toString()
> -                + " has nested directory" + item.toString());
> +            throw new HiveException("checkPaths: " + src.getPath()
> +                + " has nested directory " + item.getPath());
>            }
> {code}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HIVE-1297) error message in Hive.checkPaths dumps Java array address instead of path string

Posted by "John Sichi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-1297:
-----------------------------

    Status: Patch Available  (was: Open)

No test since this is trivial.

> error message in Hive.checkPaths dumps Java array address instead of path string
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-1297
>                 URL: https://issues.apache.org/jira/browse/HIVE-1297
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.5.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1297.1.patch
>
>
> {code}
>            if (item.isDir()) {
> -            throw new HiveException("checkPaths: " + src.toString()
> -                + " has nested directory" + item.toString());
> +            throw new HiveException("checkPaths: " + src.getPath()
> +                + " has nested directory " + item.getPath());
>            }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.