You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/23 08:10:44 UTC

[GitHub] [arrow-datafusion] Jimexist opened a new pull request #606: reuse alias map in aggregate logical planning and refactor position r…

Jimexist opened a new pull request #606:
URL: https://github.com/apache/arrow-datafusion/pull/606


   …esolving
   
   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #606: reuse alias map in aggregate logical planning and refactor position resolution

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #606:
URL: https://github.com/apache/arrow-datafusion/pull/606#issuecomment-866940596


   > yes and i believe all untouched unit tests and integration tests shall vet for that
   
   
   I agree


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Jimexist edited a comment on pull request #606: reuse alias map in aggregate logical planning and refactor position resolution

Posted by GitBox <gi...@apache.org>.
Jimexist edited a comment on pull request #606:
URL: https://github.com/apache/arrow-datafusion/pull/606#issuecomment-866845407


   > It looks like the PR stops (re)computing extract_aliases by doing so once and reusing the results
   
   yes
   
   > Thank you @Jimexist this looks like a nice cleanup -- can you confirm my understanding that this is a refactoring only (aka no behavior change)?
   
   yes and i believe all untouched unit tests and integration tests shall vet for that
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #606: reuse alias map in aggregate logical planning and refactor position resolution

Posted by GitBox <gi...@apache.org>.
alamb merged pull request #606:
URL: https://github.com/apache/arrow-datafusion/pull/606


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Jimexist commented on pull request #606: reuse alias map in aggregate logical planning and refactor position resolution

Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #606:
URL: https://github.com/apache/arrow-datafusion/pull/606#issuecomment-866845407


   > It looks like the PR stops (re)computing extract_aliases by doing so once and reusing the results
   yes
   
   > Thank you @Jimexist this looks like a nice cleanup -- can you confirm my understanding that this is a refactoring only (aka no behavior change)?
   
   yes and i believe all untouched unit tests and integration tests shall vet for that
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org