You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Aditya Sharma (Jira)" <ji...@apache.org> on 2019/08/23 13:57:00 UTC

[jira] [Comment Edited] (OFBIZ-11147) OFBiz-Camel integration

    [ https://issues.apache.org/jira/browse/OFBIZ-11147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16914284#comment-16914284 ] 

Aditya Sharma edited comment on OFBIZ-11147 at 8/23/19 1:56 PM:
----------------------------------------------------------------

Thanks Girish and Bilgin for the amazing contribution :) It will indeed add a lot of value.

I tried the plugin in the attached file and it fails on the build. 

 
{code:java}
/ofbiz-camel/src/main/java/org/apache/ofbiz/camel/loader/CamelContainer.java:54: error: method getConfiguration in class ContainerConfig cannot be applied to given types;/ofbiz-camel/src/main/java/org/apache/ofbiz/camel/loader/CamelContainer.java:54: error: method getConfiguration in class ContainerConfig cannot be applied to given types;> Building 0% > ContainerConfig.Configuration cfg = ContainerConfig.getConfiguration(name);                                                    ^  required: String,String  found: String  reason: actual and formal argument lists differ in length
 
{code}
I traced out it, it seems  there are some extra changes in tar file when compared to from Github [repository|https://github.com/bibryam/ofbiz-camel]

 
{code:java}
- ContainerConfig.Configuration cfg = ContainerConfig.getConfiguration(name, configFile);
+ ContainerConfig.Configuration cfg = ContainerConfig.getConfiguration(name);
{code}
Other than that:

As runtime extends compile-time dependencies. There should be no need to again add camel dependency as a runtime dependency.
 See
 [https://docs.gradle.org/2.12/userguide/java_plugin.html] 
 [https://docs.gradle.org/4.9/userguide/java_plugin.html#java_plugin]

I have raised a pull request for the same [#6|https://github.com/bibryam/ofbiz-camel/pull/6]


was (Author: aditya.sharma):
Thanks Girish and Bilgin for the amazing contribution :) It will indeed add a lot of value.

I tried the plugin in the attached file and it fails on the build. 

 
{code:java}
/ofbiz-camel/src/main/java/org/apache/ofbiz/camel/loader/CamelContainer.java:54: error: method getConfiguration in class ContainerConfig cannot be applied to given types;/ofbiz-camel/src/main/java/org/apache/ofbiz/camel/loader/CamelContainer.java:54: error: method getConfiguration in class ContainerConfig cannot be applied to given types;> Building 0% > ContainerConfig.Configuration cfg = ContainerConfig.getConfiguration(name);                                                    ^  required: String,String  found: String  reason: actual and formal argument lists differ in length
 
{code}
I traced out it, it seems  there are some changes in tar file from Github [repository|https://github.com/bibryam/ofbiz-camel]

 
{code:java}
- ContainerConfig.Configuration cfg = ContainerConfig.getConfiguration(name, configFile);
+ ContainerConfig.Configuration cfg = ContainerConfig.getConfiguration(name);
{code}

Other than that:

As runtime extends compile-time dependencies. There should be no need to again add camel dependency as a runtime dependency.
See
[https://docs.gradle.org/2.12/userguide/java_plugin.html] 
[https://docs.gradle.org/4.9/userguide/java_plugin.html#java_plugin]

I have raised a pull request for the same [#6|https://github.com/bibryam/ofbiz-camel/pull/6]

> OFBiz-Camel integration
> -----------------------
>
>                 Key: OFBIZ-11147
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11147
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Girish Vasmatkar
>            Assignee: Girish Vasmatkar
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: ofbiz-camel.tar.gz
>
>
> This OFBiz plug in will provide capability for OFBiz to integrate with Apache Camel. The plug in should provide capability for OFBiz to interface with various external systems via Apache Camel.
> Similarly, the integration will allow inbound communication from external system into OFBiz via Apache Camel.
> Here's the list to the ML discussion thread - 
> [https://lists.apache.org/thread.html/36ee6e3d2425ecc5eed7cf44e41e27125f7263080870bacd72ae556e@%3Cuser.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.2#803003)