You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/28 03:51:24 UTC
[GitHub] [spark-docker] Yikun opened a new pull request, #26: [SPARK-41287][INFRA] Add test workflow to help self-build image test in fork repo
Yikun opened a new pull request, #26:
URL: https://github.com/apache/spark-docker/pull/26
### What changes were proposed in this pull request?
This patch adds a test workflow to help fork repo to test image in their fork repos.
such like:
- https://github.com/Yikun/spark-docker/actions/runs/3552072792/jobs/5966742869
- https://github.com/Yikun/spark-docker/actions/runs/3561513498/jobs/5982485960
### Why are the changes needed?
Help devs/users test their own image in their fork repo
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Test in my fork repo:
https://github.com/Yikun/spark-docker/actions/workflows/test.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun commented on pull request #26: [SPARK-41287][INFRA] Add test workflow to help self-build image test in fork repo
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #26:
URL: https://github.com/apache/spark-docker/pull/26#issuecomment-1328696235
- Test all (3.3.1): https://github.com/Yikun/spark-docker/actions/runs/3562507922/jobs/5984300370
- Test r(3.3.0): https://github.com/Yikun/spark-docker/actions/runs/3561561102/jobs/5982569508
- Test python(3.3.0): https://github.com/Yikun/spark-docker/actions/runs/3561558886/jobs/5982565442
- Test scala(3.3.0): https://github.com/Yikun/spark-docker/actions/runs/3561513498/jobs/5982485960
- Test downstream image (3.3.1 python): https://github.com/Yikun/spark-docker/actions/runs/3552072792/jobs/5966742869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun commented on a diff in pull request #26: [SPARK-41287][INFRA] Add test workflow to help self-build image test in fork repo
Posted by GitBox <gi...@apache.org>.
Yikun commented on code in PR #26:
URL: https://github.com/apache/spark-docker/pull/26#discussion_r1033254961
##########
.github/workflows/main.yml:
##########
@@ -52,6 +57,11 @@ on:
required: false
type: string
default: python
+ image-tag:
+ type: string
+ description: The image tag to be tested. (Avaliable only in test workflow)
Review Comment:
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] martin-g commented on a diff in pull request #26: [SPARK-41287][INFRA] Add test workflow to help self-build image test in fork repo
Posted by GitBox <gi...@apache.org>.
martin-g commented on code in PR #26:
URL: https://github.com/apache/spark-docker/pull/26#discussion_r1033202736
##########
.github/workflows/main.yml:
##########
@@ -52,6 +57,11 @@ on:
required: false
type: string
default: python
+ image-tag:
+ type: string
+ description: The image tag to be tested. (Avaliable only in test workflow)
Review Comment:
```suggestion
description: The image tag to be tested. (Available only in test workflow)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun closed pull request #26: [SPARK-41287][INFRA] Add test workflow to help self-build image test in fork repo
Posted by GitBox <gi...@apache.org>.
Yikun closed pull request #26: [SPARK-41287][INFRA] Add test workflow to help self-build image test in fork repo
URL: https://github.com/apache/spark-docker/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark-docker] Yikun commented on pull request #26: [SPARK-41287][INFRA] Add test workflow to help self-build image test in fork repo
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #26:
URL: https://github.com/apache/spark-docker/pull/26#issuecomment-1328807609
@HyukjinKwon @martin-g Thanks, merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org