You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2016/12/20 09:41:45 UTC
[GitHub] zeppelin pull request #1786: [ZEPPELIN-1842] sync on start when anonymous al...
GitHub user khalidhuseynov opened a pull request:
https://github.com/apache/zeppelin/pull/1786
[ZEPPELIN-1842] sync on start when anonymous allowed
### What is this PR for?
this is to keep backward compatibility when it's possible to sync on start in anonymous mode.
### What type of PR is it?
Bug Fix | Improvement
### Todos
* [x] - add sync call with condition
### What is the Jira issue?
[ZEPPELIN-1842](https://issues.apache.org/jira/browse/ZEPPELIN-1842)
### How should this be tested?
1. enable secondary storage (e.g. s3, azure, [here](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/storage/storage.html#notebook-storage-in-s3))
2. keep anonymous mode without authentication
3. start zeppelin -> notes should be synced
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khalidhuseynov/incubator-zeppelin fix/sync-anonymous
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1786.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1786
----
commit 66bfa9e46603d79408e82adff76948cbbb90db26
Author: Khalid Huseynov <kh...@gmail.com>
Date: 2016-12-20T09:28:01Z
sync on start when anonymous allowed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1786: [ZEPPELIN-1842] sync on start when anonymous allowed
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1786
@khalidhuseynov yup, hopefully it can be :)
Will merge this into master if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1786: [ZEPPELIN-1842] sync on start when anonymous allowed
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1786
@khalidhuseynov Thanks for fixing. I test this on [ZeppelinHub](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/storage/storage.html#storage-in-zeppelinhub), seems it's synced well when I ran Zeppelin as anonymous user. So I can see my Zeppelin notebook in the connected ZeppelinHub instance. But one thing is (which is not in this PR's scope i guess),
even if the anonymous user shouldn't allow to see the list of other instances in ZeppelinHub, the `No value` looks a bit unnatural. Hopefully we can show this with better way.
Anyway looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1786: [ZEPPELIN-1842] sync on start when anonymous allowed
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1786
@AhyoungRyu thanks for review. you're right about `No value` field but it's not related to this issue and can be handled separately
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1786: [ZEPPELIN-1842] sync on start when anonymous allowed
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1786
this is ready for review, /cc @AhyoungRyu for help in review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1786: [ZEPPELIN-1842] sync on start when anonymous al...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1786
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---