You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/24 06:56:47 UTC

[GitHub] [flink] KarmaGYZ commented on a change in pull request #9747: [FLINK-13985] Use unsafe memory for managed memory

KarmaGYZ commented on a change in pull request #9747: [FLINK-13985] Use unsafe memory for managed memory
URL: https://github.com/apache/flink/pull/9747#discussion_r327430872
 
 

 ##########
 File path: flink-core/src/test/java/org/apache/flink/core/memory/MemorySegmentChecksTest.java
 ##########
 @@ -39,29 +39,19 @@ public void testHeapNullBuffer2() {
 		new HeapMemorySegment(null, new Object());
 	}
 
-	@Test(expected = NullPointerException.class)
-	public void testHybridHeapNullBuffer1() {
-		new HybridMemorySegment((byte[]) null);
-	}
-
 	@Test(expected = NullPointerException.class)
 	public void testHybridHeapNullBuffer2() {
 
 Review comment:
   Should we rename it `testHybridHeapNullBuffer`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services