You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2019/01/23 22:24:57 UTC

[GitHub] nwangtw commented on a change in pull request #3168: Joshfischer/aws helm fix

nwangtw commented on a change in pull request #3168: Joshfischer/aws helm fix
URL: https://github.com/apache/incubator-heron/pull/3168#discussion_r249996896
 
 

 ##########
 File path: deploy/kubernetes/helm/templates/bookie.yaml
 ##########
 @@ -144,15 +144,15 @@ spec:
             - name: data-disk
               mountPath: /bookkeeper/data/ledgers
 
-{{- if eq .Values.platform "baremetal" }}
+{{- if or (eq .Values.platform "aws") (eq .Values.platform "baremetal") }}
       volumes:
           # Mount local disks
         - name: journal-disk
           hostPath:
-            path: {{ $bookieJournalHostPath | quote }}
+            path: /bookkeeper/data/journal
 
 Review comment:
   seems like bookieJournalHostPath is not used any more here. Is it used in any other places ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services