[GitHub] [james-project] mbaechler commented on a change in pull request #255: JAMES-3435 Cassandra: No longer rely on LWT for domain and users

[GitBox <gi...@apache.org>]

mbaechler commented on a change in pull request #255:
URL: https://github.com/apache/james-project/pull/255#discussion_r512574114



##########
File path: server/data/data-library/src/test/java/org/apache/james/domainlist/lib/DomainListIdempotentContract.java
##########
@@ -84,14 +83,16 @@ default void testAddRemoveContainsSameDomain() throws DomainListException {
     }
 
     @Test
-    default void addShouldBeCaseSensitive() {
+    default void addShouldBeCaseSensitive() throws DomainListException {
         try {
             domainList().addDomain(DOMAIN_5);
+            domainList().addDomain(DOMAIN_UPPER_5);
         } catch (Exception e) {
-            fail(e.getMessage());
+            // ignore errors
         }
-        assertThatThrownBy(() -> domainList().addDomain(DOMAIN_UPPER_5))
-            .isInstanceOf(DomainListException.class);
+
+        assertThat(domainList().getDomains().stream().filter(domain -> domain.equals(DOMAIN_5) || domain.equals(DOMAIN_UPPER_5)))

Review comment:
       you don't know which domain to expect?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org