You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/19 23:55:47 UTC

[GitHub] [iceberg] rdblue commented on a diff in pull request #5799: Serialize statistics inside Table Metadata

rdblue commented on code in PR #5799:
URL: https://github.com/apache/iceberg/pull/5799#discussion_r974774179


##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -225,6 +226,12 @@ public static void toJson(TableMetadata metadata, JsonGenerator generator) throw
     }
     generator.writeEndArray();
 
+    generator.writeArrayFieldStart(STATISTICS);

Review Comment:
   Can you also add deserialization? Generally when we update a parser we want to update both.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org