You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "Tonitzpp (via GitHub)" <gi...@apache.org> on 2026/04/02 09:10:03 UTC

[PR] Improves the network offering creation form [cloudstack]

Tonitzpp opened a new pull request, #12951:
URL: https://github.com/apache/cloudstack/pull/12951

   ### Description
   
   Currently, when creating a new network offering through the CloudStack graphical interface it is not possible to specify the `specifyipranges` parameter. Furthermore, the default value of the `egressdefaultpolicy` field is `DENY`, while the API's default is `ALLOW`.
   
   This PR made modifications to add the `specifyipranges` field to the form and change the default value of `egressdefaultpolicy`.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] Build/CI
   - [ ] Test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   In the CloudStack graphical interface, I opened the create new network offering form and checked the new `specifyipranges` parameter was only in the `Isolated` guest type and checked that the default value of `egressdefaultpolicy` is now `Allow`. After creating the new network offering, I created a new network and it was observed in the form that the fields to specify the IPs ranges were present.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "GeanJair (via GitHub)" <gi...@apache.org>.
GeanJair commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-5640310773

   Hello, @abh1sar 
   
   I applied the suggestions on commit ad4307e1e15823a56a813790835b5b68c8f57f91.
   
   I tested it manually and verified that the `specifyipranges` item in the form is correctly removed when Source Nat option is checked.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-5980892380

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12951 (QA-JID-999)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-5175545166

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "Tonitzpp (via GitHub)" <gi...@apache.org>.
Tonitzpp commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-4214575436

   @DaanHoogland, I tested the changes in both 4.20 and 4.22 versions, and it works in both of them. I will re-target my PR to the 4.20 branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-4220281474

   @sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-5978216288

   > Tested it locally and it worked as intended.
   > 
   > * Verified that the `specifyipranges` item was being shown in the form only for isolated networks.
   > * Verified that the `specifyipranges` item was being correctly removed from the form when cheking Source Nat option.
   > * Successfully created a network offering with `specifyipranges` enabled.
   
   Does this mean LGTY, @abh1sar ? or is there still something that needs doing before merging?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "Tonitzpp (via GitHub)" <gi...@apache.org>.
Tonitzpp commented on code in PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#discussion_r3073514628


##########
ui/src/views/offering/AddNetworkOffering.vue:
##########
@@ -681,7 +691,8 @@ export default {
         isolation: 'dedicated',
         conservemode: true,
         availability: 'optional',
-        egressdefaultpolicy: 'deny',
+        specifyipranges: false,
+        egressdefaultpolicy: 'allow',

Review Comment:
   @DaanHoogland, You're right, I'll remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-4177941402

   ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12951?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 3.52%. Comparing base ([`9cc6c09`](https://app.codecov.io/gh/apache/cloudstack/commit/9cc6c09b9eb9fa8f52795574c2f855aeca840f2f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34f055d`](https://app.codecov.io/gh/apache/cloudstack/commit/34f055dea97e6f3d6ff270b61d8e3003cbbd64d9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 52 commits behind head on main.
   > :exclamation:  There is a different number of reports uploaded between BASE (9cc6c09) and HEAD (34f055d). Click for more details.
   > 
   > <details><summary>HEAD has 1 upload less than BASE</summary>
   >
   >| Flag | BASE (9cc6c09) | HEAD (34f055d) |
   >|------|------|------|
   >|unittests|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##               main   #12951       +/-   ##
   =============================================
   - Coverage     17.93%    3.52%   -14.41%     
   =============================================
     Files          5939      464     -5475     
     Lines        533147    40065   -493082     
     Branches      65237     7534    -57703     
   =============================================
   - Hits          95601     1414    -94187     
   + Misses       426804    38463   -388341     
   + Partials      10742      188    -10554     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12951/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.52% <ø> (-0.14%)` | :arrow_down: |
   | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/12951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12951?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-5175533251

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-4178042763

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12951 (QA-JID-904)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-4220469103

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12951 (QA-JID-906)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "abh1sar (via GitHub)" <gi...@apache.org>.
abh1sar commented on code in PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#discussion_r3968061400


##########
ui/src/views/offering/AddNetworkOffering.vue:
##########
@@ -111,6 +111,16 @@
             </a-form-item>
           </a-col>
         </a-row>
+        <a-row :gutter="12">
+          <a-col :md="12" :lg="12">
+            <a-form-item name="specifyipranges" ref="specifyipranges" v-if="guestType === 'isolated'">

Review Comment:
   ```suggestion
               <a-form-item name="specifyipranges" ref="specifyipranges" v-if="guestType === 'isolated' && !sourceNatServiceChecked">
   ```
   Otherwise it fail in the backend
   
   ```
   if (specifyIpRanges) {
       if (type == GuestType.Isolated) {
           if (serviceProviderMap.containsKey(Service.SourceNat)) {
               throw new InvalidParameterValueException("SpecifyIpRanges can only be true for Shared network offerings and Isolated with no SourceNat service");
           }
       }
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#discussion_r3063180409


##########
ui/src/views/offering/AddNetworkOffering.vue:
##########
@@ -681,7 +691,8 @@ export default {
         isolation: 'dedicated',
         conservemode: true,
         availability: 'optional',
-        egressdefaultpolicy: 'deny',
+        specifyipranges: false,
+        egressdefaultpolicy: 'allow',

Review Comment:
   @Tonitzpp , i have my doubts about this part of the change. Someone decided that it is better to deny outgoing traffic be default (for UI users) and that seems reasonable to me. No reason to allign UI and API on this I think as API users are usually better versed at hardening their VMs/networks. If allignment is strictly necessary (not to me) I think we should change the API on this point, in another PR. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-4205464161

   @Tonitzpp , this is currently targetted for main/23, but I think it may be applicable for 22 or even 20 as well. Care to check?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "abh1sar (via GitHub)" <gi...@apache.org>.
abh1sar commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-5980697911

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "bernardodemarco (via GitHub)" <gi...@apache.org>.
bernardodemarco commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-4177870620

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-4215052760

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#discussion_r3031450126


##########
ui/src/views/offering/AddNetworkOffering.vue:
##########
@@ -111,6 +111,18 @@
             </a-form-item>
           </a-col>
         </a-row>
+        <a-row :gutter="12">
+          <a-col :md="12" :lg="12">
+            <a-form-item name="specifyipranges" ref="specifyipranges" v-if="guestType === 'isolated'">
+              <template #label>
+                <tooltip-label :title="$t('label.specifyipranges')" :tooltip="apiParams.specifyipranges.description"/>
+              </template>
+              <a-switch v-model:checked="form.specifyipranges" />
+            </a-form-item>
+          </a-col>
+          <a-col :md="12" :lg="12">
+          </a-col>

Review Comment:
   The new `specifyipranges` row includes an empty `<a-col>` (md/lg=12) which adds unnecessary markup and can make the layout harder to maintain. Consider removing the empty column or changing the layout to a single full-width column for this row.



##########
ui/src/views/offering/AddNetworkOffering.vue:
##########
@@ -1129,6 +1142,9 @@ export default {
           if (values.specifyvlan === true) {
             params.specifyvlan = true
           }
+
+          params.specifyipranges = values.specifyipranges
+

Review Comment:
   `specifyipranges` will already be added to `params` by the generic `keys.forEach` loop (it’s not in `ignoredKeys` and boolean `false` passes the null/undefined checks). The additional `params.specifyipranges = values.specifyipranges` assignment in the isolated branch is therefore redundant; consider either adding `specifyipranges` to `ignoredKeys` and handling it only in the guest-type branches, or removing this extra assignment to avoid duplicate logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-5980707703

   @abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-4177878412

   @bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-5175543736

   @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-4215048797

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "abh1sar (via GitHub)" <gi...@apache.org>.
abh1sar commented on code in PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#discussion_r3986898573


##########
ui/src/views/offering/AddNetworkOffering.vue:
##########
@@ -111,6 +111,16 @@
             </a-form-item>
           </a-col>
         </a-row>
+        <a-row :gutter="12">
+          <a-col :md="12" :lg="12">
+            <a-form-item name="specifyipranges" ref="specifyipranges" v-if="guestType === 'isolated'">

Review Comment:
   @Tonitzpp please check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-4215412085

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17426


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-4220270840

   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-5175528343

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#issuecomment-5175710394

   UI build: :heavy_check_mark:
   Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12951 (QA-JID-968)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improves the network offering creation form [cloudstack]

Posted by "Damans227 (via GitHub)" <gi...@apache.org>.
Damans227 commented on code in PR #12951:
URL: https://github.com/apache/cloudstack/pull/12951#discussion_r4272817056


##########
ui/src/views/offering/AddNetworkOffering.vue:
##########
@@ -1062,6 +1073,9 @@ export default {
           if (values.specifyvlan === true) {
             params.specifyvlan = true
           }
+
+          params.specifyipranges = values.specifyipranges

Review Comment:
   what happens if someone turns this on and then ticks source nat again? the switch hides but the value is still sent, so the create fails



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org