You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tomee.apache.org by David Salter <we...@gmail.com> on 2019/08/05 12:51:54 UTC

JKS Keystore ?

Hi,

I’m looking at https://issues.apache.org/jira/browse/TOMEE-2586 <https://issues.apache.org/jira/browse/TOMEE-2586> which is to make one of the samples work on Java 11.

I’ve got a fix for this on Java 11 by specifying the keystore type as JKS.  Is this ok for this example given that its a complete Java example?  When using JKS, the sample works correctly on Java 8 and Java 11.

Ta.

David.

Re: JKS Keystore ?

Posted by David Salter <we...@gmail.com>.

Thanks,

I’ll get the PR completed now.  Can you assign TOMEE-2586 to me ?

Thanks.

David.

> On 5 Aug 2019, at 14:31, Jonathan Gallimore <jo...@gmail.com> wrote:
> 
> Certainly sounds good - can't see any reason why that would be an issue.
> Can you send a PR if you haven't already?
> 
> Cheers
> 
> Jon
> 
> On Mon, Aug 5, 2019 at 1:52 PM David Salter <we...@gmail.com>
> wrote:
> 
>> Hi,
>> 
>> I’m looking at https://issues.apache.org/jira/browse/TOMEE-2586 <
>> https://issues.apache.org/jira/browse/TOMEE-2586> which is to make one of
>> the samples work on Java 11.
>> 
>> I’ve got a fix for this on Java 11 by specifying the keystore type as
>> JKS.  Is this ok for this example given that its a complete Java example?
>> When using JKS, the sample works correctly on Java 8 and Java 11.
>> 
>> Ta.
>> 
>> David.

Re: JKS Keystore ?

Posted by David Salter <we...@gmail.com>.

Hi,

I’ve created a PR for this:

https://github.com/apache/tomee/pull/530 <https://github.com/apache/tomee/pull/530>

Let me know if it looks ok.

Thanks.

David.


> On 5 Aug 2019, at 14:31, Jonathan Gallimore <jo...@gmail.com> wrote:
> 
> Certainly sounds good - can't see any reason why that would be an issue.
> Can you send a PR if you haven't already?
> 
> Cheers
> 
> Jon
> 
> On Mon, Aug 5, 2019 at 1:52 PM David Salter <we...@gmail.com>
> wrote:
> 
>> Hi,
>> 
>> I’m looking at https://issues.apache.org/jira/browse/TOMEE-2586 <
>> https://issues.apache.org/jira/browse/TOMEE-2586> which is to make one of
>> the samples work on Java 11.
>> 
>> I’ve got a fix for this on Java 11 by specifying the keystore type as
>> JKS.  Is this ok for this example given that its a complete Java example?
>> When using JKS, the sample works correctly on Java 8 and Java 11.
>> 
>> Ta.
>> 
>> David.

Re: JKS Keystore ?

Posted by Jonathan Gallimore <jo...@gmail.com>.

Certainly sounds good - can't see any reason why that would be an issue.
Can you send a PR if you haven't already?

Cheers

Jon

On Mon, Aug 5, 2019 at 1:52 PM David Salter <we...@gmail.com>
wrote:

> Hi,
>
> I’m looking at https://issues.apache.org/jira/browse/TOMEE-2586 <
> https://issues.apache.org/jira/browse/TOMEE-2586> which is to make one of
> the samples work on Java 11.
>
> I’ve got a fix for this on Java 11 by specifying the keystore type as
> JKS.  Is this ok for this example given that its a complete Java example?
> When using JKS, the sample works correctly on Java 8 and Java 11.
>
> Ta.
>
> David.