You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/02/07 19:22:03 UTC
Re: Review Request 65402: Windows: Used Unicode API to duplicate
sockets.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65402/
-----------------------------------------------------------
(Updated Feb. 7, 2018, 11:22 a.m.)
Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
Summary (updated)
-----------------
Windows: Used Unicode API to duplicate sockets.
Repository: mesos
Description
-------
The CRT API for duplicating file handles is left as-is because
`WindowsFD` currently gets a CRT `int` file descriptor, which
necessitates using `_dup` instead of `DuplicateHandle`. Furthermore, the
latter API does not appear compatible with handles used to redirect
stdout/stderr/stdin for subprocesses.
Diffs (updated)
-----
3rdparty/stout/include/stout/os/windows/dup.hpp b37aaa6429e0e7b4340e86c078f5c543e443bdcd
Diff: https://reviews.apache.org/r/65402/diff/2/
Changes: https://reviews.apache.org/r/65402/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 65402: Windows: Used Unicode API to duplicate
sockets.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Feb. 7, 2018, 12:49 p.m., Akash Gupta wrote:
> > 3rdparty/stout/include/stout/os/windows/dup.hpp
> > Line 30 (original), 33 (patched)
> > <https://reviews.apache.org/r/65402/diff/2/?file=1954106#file1954106line33>
> >
> > It's not a change for this patch, but we should probably look to make `os::dup` not inheritable by default and hunt down cases that we actually need inheritance.
Totally agree, even left a TODO for that.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65402/#review197030
-----------------------------------------------------------
On Feb. 7, 2018, 11:22 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65402/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 11:22 a.m.)
>
>
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The CRT API for duplicating file handles is left as-is because
> `WindowsFD` currently gets a CRT `int` file descriptor, which
> necessitates using `_dup` instead of `DuplicateHandle`. Furthermore, the
> latter API does not appear compatible with handles used to redirect
> stdout/stderr/stdin for subprocesses.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/dup.hpp b37aaa6429e0e7b4340e86c078f5c543e443bdcd
>
>
> Diff: https://reviews.apache.org/r/65402/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65402: Windows: Used Unicode API to duplicate
sockets.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65402/#review197030
-----------------------------------------------------------
Ship it!
3rdparty/stout/include/stout/os/windows/dup.hpp
Line 30 (original), 33 (patched)
<https://reviews.apache.org/r/65402/#comment277138>
It's not a change for this patch, but we should probably look to make `os::dup` not inheritable by default and hunt down cases that we actually need inheritance.
- Akash Gupta
On Feb. 7, 2018, 7:22 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65402/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 7:22 p.m.)
>
>
> Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The CRT API for duplicating file handles is left as-is because
> `WindowsFD` currently gets a CRT `int` file descriptor, which
> necessitates using `_dup` instead of `DuplicateHandle`. Furthermore, the
> latter API does not appear compatible with handles used to redirect
> stdout/stderr/stdin for subprocesses.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/os/windows/dup.hpp b37aaa6429e0e7b4340e86c078f5c543e443bdcd
>
>
> Diff: https://reviews.apache.org/r/65402/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>