You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/01 02:45:53 UTC

[GitHub] [flink] JingsongLi commented on issue #10039: [FLINK-14262][table] Support referencing function with fully/partially qualified names in SQL

JingsongLi commented on issue #10039: [FLINK-14262][table]  Support referencing function with fully/partially qualified names in SQL
URL: https://github.com/apache/flink/pull/10039#issuecomment-548645119
 
 
   > @JingsongLi Thanks a lot for the PR!
   > 
   > I wonder if exposing catalog manager via FunctionCatalog is not ideal. I took a look at the code, and found we can pass catalog manager into FunctionCatalogOperatorTable thru PlannerBase and PlannerContext, which already have a hold on catalog manager. That might be a bit cleaner.
   > 
   > Otherwise, LGTM.
   
   Agree, another place to use function catalog is in `RexNodeToExpressionConverter`, we should expose CatalogManager in `FlinkContext`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services