[jira] Updated: (TAPESTRY-773) Excess code generate for required parameters

["Jesse Kuhnert (JIRA)" <de...@tapestry.apache.org>]

     [ https://issues.apache.org/jira/browse/TAPESTRY-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Kuhnert updated TAPESTRY-773:
-----------------------------------

    Fix Version/s:     (was: 4.1.5)
                   4.1.6

> Excess code generate for required parameters
> --------------------------------------------
>
>                 Key: TAPESTRY-773
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-773
>             Project: Tapestry
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: 4.0
>            Reporter: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 4.1.6
>
>
> When Tapestry is generating code to support component parameters, it generates code such as the following for the setter method:
> public void setRefresh(org.apache.tapestry.IActionListener $1)
> {
>   if (! isInActiveState())
>   {
>     _$refresh$Default = $1;
>     return;
>   }
>   org.apache.tapestry.IBinding binding = getBinding("refresh");
>   if (binding == null)
>     throw new org.apache.hivemind.ApplicationRuntimeException("Parameter 'refresh' is not bound and can not be updated.");
>   binding.setObject(($w) $1);
>   if (isRendering())
>   {
>     _$refresh = $1;
>     _$refresh$Cached = true;
>   }
> }
> The binding == null check in the middle should be omitted for required parameters, which will always be bound. This will save (a tiny amount of) processing time when generating this code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org