You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/10/15 19:28:19 UTC
[kudu-CR] [docs] Automatically generate a metrics reference page
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16604
Change subject: [docs] Automatically generate a metrics reference page
......................................................................
[docs] Automatically generate a metrics reference page
This patch adds an generated metrics page that is very similar to
the existing command line and configuration references.
A new `—dump_metrics_xml` flag was added so I could dump the
metrics and then translate them to an adoc using xslt.
Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
---
M docs/administration.adoc
A docs/metrics_reference.adoc
M docs/support/jekyll-templates/document.html.erb
M docs/support/scripts/make_docs.sh
A docs/support/xsl/metrics_to_asciidoc.xsl
M src/kudu/util/flags.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
8 files changed, 255 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/16604/1
--
To view, visit http://gerrit.cloudera.org:8080/16604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
Gerrit-Change-Number: 16604
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [docs] Automatically generate a metrics reference page
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16604
to look at the new patch set (#3).
Change subject: [docs] Automatically generate a metrics reference page
......................................................................
[docs] Automatically generate a metrics reference page
This patch adds an generated metrics page that is very similar to
the existing command line and configuration references.
A new `—dump_metrics_xml` flag was added so I could dump the
metrics and then translate them to an adoc using xslt.
Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
---
M docs/administration.adoc
A docs/metrics_reference.adoc
M docs/support/jekyll-templates/document.html.erb
M docs/support/scripts/make_docs.sh
A docs/support/xsl/metrics_to_asciidoc.xsl
M src/kudu/util/flags.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
8 files changed, 254 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/16604/3
--
To view, visit http://gerrit.cloudera.org:8080/16604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
Gerrit-Change-Number: 16604
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] Automatically generate a metrics reference page
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16604
to look at the new patch set (#2).
Change subject: [docs] Automatically generate a metrics reference page
......................................................................
[docs] Automatically generate a metrics reference page
This patch adds an generated metrics page that is very similar to
the existing command line and configuration references.
A new `—dump_metrics_xml` flag was added so I could dump the
metrics and then translate them to an adoc using xslt.
Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
---
M docs/administration.adoc
A docs/metrics_reference.adoc
M docs/support/jekyll-templates/document.html.erb
M docs/support/scripts/make_docs.sh
A docs/support/xsl/metrics_to_asciidoc.xsl
M src/kudu/util/flags.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
8 files changed, 255 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/16604/2
--
To view, visit http://gerrit.cloudera.org:8080/16604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
Gerrit-Change-Number: 16604
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] Automatically generate a metrics reference page
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16604 )
Change subject: [docs] Automatically generate a metrics reference page
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16604/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/16604/1/docs/administration.adoc@118
PS1, Line 118: * `warn` - Metrics which can often indicate operational oddities that may need more investigation.
nit: seems this line is too long
--
To view, visit http://gerrit.cloudera.org:8080/16604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
Gerrit-Change-Number: 16604
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Oct 2020 15:56:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Automatically generate a metrics reference page
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16604 )
Change subject: [docs] Automatically generate a metrics reference page
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.h
File src/kudu/util/metrics.h:
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.h@923
PS1, Line 923:
> Done
I think Alexey meant the indentation, not the empty line.
--
To view, visit http://gerrit.cloudera.org:8080/16604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
Gerrit-Change-Number: 16604
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Oct 2020 16:57:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Automatically generate a metrics reference page
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16604 )
Change subject: [docs] Automatically generate a metrics reference page
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.h
File src/kudu/util/metrics.h:
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.h@923
PS1, Line 923:
> Done
style nit: well, 'private' should be prefixed with one space, I guess :) I should have been more specific
--
To view, visit http://gerrit.cloudera.org:8080/16604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
Gerrit-Change-Number: 16604
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Oct 2020 16:57:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Automatically generate a metrics reference page
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16604 )
Change subject: [docs] Automatically generate a metrics reference page
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
Gerrit-Change-Number: 16604
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Oct 2020 17:45:09 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Automatically generate a metrics reference page
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16604 )
Change subject: [docs] Automatically generate a metrics reference page
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/16604/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/16604/1/docs/administration.adoc@118
PS1, Line 118: * `warn` - Metrics which can often indicate operational oddities that may need more investigation.
> nit: seems this line is too long
Done
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.h
File src/kudu/util/metrics.h:
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.h@923
PS1, Line 923: private
> style nit: add a space before the 'private' label
Done
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.cc
File src/kudu/util/metrics.cc:
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.cc@620
PS1, Line 620: std::ostringstream s;
> Why to use std::ostringstream here at all? Could every element be output r
Done
--
To view, visit http://gerrit.cloudera.org:8080/16604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
Gerrit-Change-Number: 16604
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Oct 2020 16:00:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Automatically generate a metrics reference page
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16604 )
Change subject: [docs] Automatically generate a metrics reference page
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.h
File src/kudu/util/metrics.h:
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.h@923
PS1, Line 923: private
> I think Alexey meant the indentation, not the empty line.
Done
--
To view, visit http://gerrit.cloudera.org:8080/16604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
Gerrit-Change-Number: 16604
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Oct 2020 17:09:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Automatically generate a metrics reference page
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16604 )
Change subject: [docs] Automatically generate a metrics reference page
......................................................................
Patch Set 1:
(2 comments)
Thank you for adding this.
Looks good to me, just a couple of nits.
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.h
File src/kudu/util/metrics.h:
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.h@923
PS1, Line 923: private
style nit: add a space before the 'private' label
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.cc
File src/kudu/util/metrics.cc:
http://gerrit.cloudera.org:8080/#/c/16604/1/src/kudu/util/metrics.cc@620
PS1, Line 620: std::ostringstream s;
Why to use std::ostringstream here at all? Could every element be output right into std::cout right away?
--
To view, visit http://gerrit.cloudera.org:8080/16604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
Gerrit-Change-Number: 16604
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Oct 2020 15:42:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Automatically generate a metrics reference page
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16604 )
Change subject: [docs] Automatically generate a metrics reference page
......................................................................
[docs] Automatically generate a metrics reference page
This patch adds an generated metrics page that is very similar to
the existing command line and configuration references.
A new `—dump_metrics_xml` flag was added so I could dump the
metrics and then translate them to an adoc using xslt.
Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
Reviewed-on: http://gerrit.cloudera.org:8080/16604
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docs/administration.adoc
A docs/metrics_reference.adoc
M docs/support/jekyll-templates/document.html.erb
M docs/support/scripts/make_docs.sh
A docs/support/xsl/metrics_to_asciidoc.xsl
M src/kudu/util/flags.cc
M src/kudu/util/metrics.cc
M src/kudu/util/metrics.h
8 files changed, 254 insertions(+), 7 deletions(-)
Approvals:
Attila Bukor: Looks good to me, approved
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
Gerrit-Change-Number: 16604
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [docs] Automatically generate a metrics reference page
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16604 )
Change subject: [docs] Automatically generate a metrics reference page
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I052a043a10a258fd52ff6cc7779e37becb0a3a35
Gerrit-Change-Number: 16604
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 19 Oct 2020 17:22:37 +0000
Gerrit-HasComments: No