You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "ByteYue (via GitHub)" <gi...@apache.org> on 2024/03/13 07:55:33 UTC
[PR] Pick "[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079" [doris]
ByteYue opened a new pull request, #32178:
URL: https://github.com/apache/doris/pull/32178
## Proposed changes
Issue Number: close #xxx
same as master #32079
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Pick "[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079" [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #32178:
URL: https://github.com/apache/doris/pull/32178#issuecomment-1993876725
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Pick "[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079" [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32178:
URL: https://github.com/apache/doris/pull/32178#issuecomment-1993970636
<details>
<summary>ClickBench: <b>Total hot run time: 30.94 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f5497cf60fda411596a42796d3edbbe852e4f93e, data reload: false
query1 0.02 0.02 0.02
query2 0.06 0.02 0.02
query3 0.25 0.05 0.05
query4 1.78 0.06 0.07
query5 0.53 0.53 0.51
query6 1.24 0.63 0.62
query7 0.01 0.01 0.01
query8 0.04 0.02 0.02
query9 0.54 0.48 0.48
query10 0.55 0.53 0.53
query11 0.13 0.08 0.09
query12 0.11 0.09 0.09
query13 0.62 0.61 0.61
query14 0.78 0.81 0.80
query15 0.78 0.76 0.77
query16 0.36 0.37 0.36
query17 0.98 1.02 0.99
query18 0.23 0.24 0.26
query19 1.86 1.82 1.83
query20 0.02 0.00 0.01
query21 15.46 0.55 0.56
query22 2.02 2.46 1.78
query23 17.40 1.03 1.04
query24 6.56 1.71 0.94
query25 0.38 0.11 0.04
query26 0.71 0.16 0.15
query27 0.05 0.04 0.03
query28 6.26 0.79 0.78
query29 12.62 2.36 2.30
query30 0.60 0.51 0.52
query31 2.81 0.39 0.37
query32 3.39 0.50 0.50
query33 3.07 3.14 3.02
query34 15.25 4.82 4.78
query35 4.84 4.88 4.81
query36 1.06 1.02 1.02
query37 0.06 0.06 0.05
query38 0.03 0.03 0.02
query39 0.02 0.02 0.02
query40 0.16 0.15 0.13
query41 0.07 0.01 0.01
query42 0.02 0.01 0.02
query43 0.02 0.02 0.02
Total cold run time: 103.75 s
Total hot run time: 30.94 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Pick "[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079" [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32178:
URL: https://github.com/apache/doris/pull/32178#issuecomment-1993976619
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit f5497cf60fda411596a42796d3edbbe852e4f93e with default session variables
Stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 20.3 seconds inserted 10000000 Rows, about 492K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Pick "[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079" [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32178:
URL: https://github.com/apache/doris/pull/32178#issuecomment-1993768038
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Pick "[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079" [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32178:
URL: https://github.com/apache/doris/pull/32178#issuecomment-1993920979
TeamCity be ut coverage result:
Function Coverage: 37.80% (8040/21268)
Line Coverage: 29.49% (65606/222502)
Region Coverage: 28.96% (33761/116591)
Branch Coverage: 24.79% (17320/69856)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f5497cf60fda411596a42796d3edbbe852e4f93e_f5497cf60fda411596a42796d3edbbe852e4f93e/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Pick "[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079" [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32178:
URL: https://github.com/apache/doris/pull/32178#issuecomment-1993758844
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Pick "[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079" [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32178:
URL: https://github.com/apache/doris/pull/32178#issuecomment-1993911171
<details>
<summary>TPC-H: <b>Total hot run time: 49890 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f5497cf60fda411596a42796d3edbbe852e4f93e, data reload: false
------ Round 1 ----------------------------------
q1 17816 4374 4336 4336
q2 2045 153 144 144
q3 10352 1905 1947 1905
q4 10176 1255 1284 1255
q5 8661 3959 4050 3959
q6 230 128 122 122
q7 2069 1594 1587 1587
q8 9271 2714 2717 2714
q9 10861 10539 10475 10475
q10 8688 3508 3519 3508
q11 417 228 241 228
q12 461 302 311 302
q13 18358 3964 4017 3964
q14 357 319 327 319
q15 494 454 450 450
q16 700 607 588 588
q17 1144 956 957 956
q18 7307 6794 6908 6794
q19 1699 1583 1518 1518
q20 521 316 298 298
q21 4386 4076 4113 4076
q22 502 397 392 392
Total cold run time: 116515 ms
Total hot run time: 49890 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4320 4310 4284 4284
q2 325 218 221 218
q3 4159 4169 4159 4159
q4 2765 2742 2751 2742
q5 7223 7186 7137 7137
q6 239 118 117 117
q7 3239 2833 2819 2819
q8 4325 4483 4448 4448
q9 17077 17125 17006 17006
q10 4277 4289 4277 4277
q11 760 687 700 687
q12 1034 837 855 837
q13 7201 3721 3729 3721
q14 446 425 416 416
q15 491 451 459 451
q16 761 704 711 704
q17 3828 3856 3897 3856
q18 8856 8798 8726 8726
q19 1710 1715 1669 1669
q20 2347 2153 2134 2134
q21 8501 8516 8538 8516
q22 1040 963 961 961
Total cold run time: 84924 ms
Total hot run time: 79885 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Pick "[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079" [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32178:
URL: https://github.com/apache/doris/pull/32178#issuecomment-1993960739
<details>
<summary>TPC-DS: <b>Total hot run time: 202853 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f5497cf60fda411596a42796d3edbbe852e4f93e, data reload: false
query1 931 386 378 378
query2 6520 2334 2255 2255
query3 6915 197 197 197
query4 20174 18039 18104 18039
query5 19714 6471 6502 6471
query6 273 212 222 212
query7 4154 290 296 290
query8 257 220 231 220
query9 3108 2713 2605 2605
query10 408 286 290 286
query11 11480 10753 10700 10700
query12 119 73 70 70
query13 5574 648 629 629
query14 17998 13696 13782 13696
query15 363 233 234 233
query16 6464 264 269 264
query17 1730 1470 867 867
query18 2318 413 399 399
query19 200 147 147 147
query20 73 80 71 71
query21 186 92 92 92
query22 5395 5077 5141 5077
query23 32661 32056 31944 31944
query24 6951 6539 6480 6480
query25 521 420 430 420
query26 521 159 156 156
query27 1899 292 292 292
query28 6104 2203 2168 2168
query29 2937 2722 2645 2645
query30 245 165 161 161
query31 903 772 702 702
query32 66 59 52 52
query33 401 257 245 245
query34 870 463 510 463
query35 1085 862 824 824
query36 1461 1511 1585 1511
query37 93 59 65 59
query38 3024 2939 2904 2904
query39 1379 1310 1316 1310
query40 202 94 103 94
query41 40 33 32 32
query42 84 82 88 82
query43 667 626 572 572
query44 1139 711 715 711
query45 242 228 226 226
query46 1224 991 958 958
query47 1843 1652 1778 1652
query48 977 663 659 659
query49 612 357 368 357
query50 868 597 610 597
query51 4805 4621 4577 4577
query52 101 81 82 81
query53 443 332 325 325
query54 2628 2458 2449 2449
query55 81 76 71 71
query56 199 205 204 204
query57 1157 1069 1110 1069
query58 215 220 198 198
query59 3471 3357 3487 3357
query60 200 191 191 191
query61 87 83 84 83
query62 806 530 527 527
query63 469 331 331 331
query64 2400 1438 1458 1438
query65 3638 3541 3540 3540
query66 816 380 364 364
query67 15932 17904 15296 15296
query68 8431 658 669 658
query69 561 350 349 349
query70 1869 1953 1954 1953
query71 405 301 305 301
query72 6444 3512 3474 3474
query73 742 312 319 312
query74 6339 5869 5905 5869
query75 4531 3792 3621 3621
query76 4578 1173 1194 1173
query77 546 246 251 246
query78 12501 11836 11594 11594
query79 7507 627 652 627
query80 1172 386 389 386
query81 498 231 231 231
query82 1486 98 98 98
query83 174 136 132 132
query84 266 74 67 67
query85 970 282 282 282
query86 398 375 374 374
query87 3255 3003 2998 2998
query88 5031 2341 2315 2315
query89 367 290 283 283
query90 1856 212 205 205
query91 150 115 119 115
query92 59 51 49 49
query93 3794 590 573 573
query94 781 209 202 202
query95 1091 1067 1077 1067
query96 628 323 328 323
query97 6519 6289 6392 6289
query98 191 177 174 174
query99 2833 938 958 938
Total cold run time: 306794 ms
Total hot run time: 202853 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Pick "[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079" [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #32178:
URL: https://github.com/apache/doris/pull/32178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org